Add ScriptPromiseResolver::detach

Add ScriptPromiseResolver::detach

A ScriptPromiseResolver requires to be resolved or rejected before it is
destructed. One the other hand, some APIs need to "detach" promise in certain
cases, i.e. they need to leave the associated promise pending forever. This
change adds ScriptPromiseResolver::detach for the use case.

BUG=None
R=haraken@chromium.org

Committed: https://crrev.com/2776b29daa5d7adbff41bbfebaaf7b82de5b5a2c
Cr-Commit-Position: refs/heads/master@{#375658}

[yhirano, 2016-02-13 17:39:34]

I don't want many people to call this function, and "clear" is a name many
people want to call. So I chose "detach".

[haraken, 2016-02-15 00:49:49]

On 2016/02/13 17:39:34, yhirano wrote:
> I don't want many people to call this function, and "clear" is a name many
> people want to call. So I chose "detach".

LGTM

Help me understand: When do we need the "detach" behavior? It looks really weird
that a promise is silently detached without getting resolved or rejected.

[yhirano, 2016-02-15 01:12:18]

On 2016/02/15 00:49:49, haraken wrote:
> On 2016/02/13 17:39:34, yhirano wrote:
> > I don't want many people to call this function, and "clear" is a name many
> > people want to call. So I chose "detach".
> 
> LGTM
> 
> Help me understand: When do we need the "detach" behavior? It looks really
weird
> that a promise is silently detached without getting resolved or rejected.

https://codereview.chromium.org/1661493002/#msg47

[yhirano, 2016-02-16 19:40:29]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-02-16 19:40:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696553005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696553005/20001

[commit-bot: I haz the power, 2016-02-16 20:54:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:54:49]

Description was changed from

==========
Add ScriptPromiseResolver::detach

A ScriptPromiseResolver requires to be resolved or rejected before it is
destructed. One the other hand, some APIs need to "detach" promise in certain
cases, i.e. they need to leave the associated promise pending forever. This
change adds ScriptPromiseResolver::detach for the use case.

BUG=None
R=haraken@chromium.org
==========

to

==========
Add ScriptPromiseResolver::detach

A ScriptPromiseResolver requires to be resolved or rejected before it is
destructed. One the other hand, some APIs need to "detach" promise in certain
cases, i.e. they need to leave the associated promise pending forever. This
change adds ScriptPromiseResolver::detach for the use case.

BUG=None
R=haraken@chromium.org

Committed: https://crrev.com/2776b29daa5d7adbff41bbfebaaf7b82de5b5a2c
Cr-Commit-Position: refs/heads/master@{#375658}
==========

[commit-bot: I haz the power, 2016-02-16 22:54:49]

Patchset 2 (id:??) landed as
https://crrev.com/2776b29daa5d7adbff41bbfebaaf7b82de5b5a2c
Cr-Commit-Position: refs/heads/master@{#375658}