Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1696513002: DevTools: move protocol-related generators into inspector subfolder. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
alph
CC:
chromium-reviews, shans, tzik, mlamouri+watch-screen-orientation_chromium.org, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, timvolodine, caseq+blink_chromium.org, aboxhall, mvanouwerkerk+watch_chromium.org, aboxhall+watch_chromium.org, nhiroki, je_julie, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, cmumford, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, jsbell+idb_chromium.org, plundblad+watch_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move protocol-related generators into inspector subfolder. BUG=580337 NOPRESUBMIT=true Committed: https://crrev.com/b4b1bdc22eabec57d57b92968a4fbf882446dfda Cr-Commit-Position: refs/heads/master@{#375109}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1252 lines, -5026 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 4 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 1 5 chunks +0 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core_generated.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/BUILD.gn View 2 chunks +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py View 1 chunk +0 lines, -2123 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/CodeGeneratorInspectorStrings.py View 1 chunk +0 lines, -907 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 2 7 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 2 5 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 2 4 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 36 chunks +65 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 5 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 2 8 chunks +15 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 2 29 chunks +59 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 13 chunks +18 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 2 3 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 11 chunks +17 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InspectorFrontendChannel.h View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 1 2 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 2 9 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 2 8 chunks +35 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 2 21 chunks +54 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 1 2 3 4 5 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 1 2 3 4 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 1 2 9 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 2 24 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 2 3 4 5 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 1 2 3 4 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 2 3 4 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 2 3 4 5 chunks +8 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/generate-inspector-protocol-version View 1 chunk +0 lines, -476 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/injected_script_externs.js View 1 chunk +0 lines, -231 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/DEPS View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/InjectedScript.h View 1 2 5 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp View 1 2 16 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/InjectedScriptHost.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/PromiseTracker.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 1 2 9 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 2 19 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8HeapProfilerAgentImpl.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8HeapProfilerAgentImpl.cpp View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.h View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8ProfilerAgentImpl.cpp View 1 2 9 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h View 1 2 3 4 6 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp View 1 2 3 4 9 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8StackTraceImpl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8StackTraceImpl.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8StringUtil.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/injected_script_externs.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/public/V8ContentSearchUtil.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/public/V8Debugger.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/public/V8DebuggerAgent.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/public/V8HeapProfilerAgent.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/public/V8ProfilerAgent.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/public/V8RuntimeAgent.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/public/V8StackTrace.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 2 11 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/InspectorFileSystemAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/InspectorFileSystemAgent.cpp View 1 2 10 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 2 5 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 1 2 6 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 3 chunks +59 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 12 chunks +30 lines, -30 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/CodeGeneratorStrings.py View 1 2 20 chunks +107 lines, -90 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp View 1 1 chunk +81 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/platform_generated.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
pfeldman
4 years, 10 months ago (2016-02-11 22:22:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696513002/1
4 years, 10 months ago (2016-02-11 22:25:41 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/145362)
4 years, 10 months ago (2016-02-11 22:36:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696513002/20001
4 years, 10 months ago (2016-02-12 00:04:03 UTC) #8
alph
lgtm https://codereview.chromium.org/1696513002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h File third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h (right): https://codereview.chromium.org/1696513002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h#newcode46 third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:46: class Frontend; blink::Frontend sounds too generic as well ...
4 years, 10 months ago (2016-02-12 00:21:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696513002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696513002/60001
4 years, 10 months ago (2016-02-12 01:30:37 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/21040) android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-12 01:36:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696513002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696513002/80001
4 years, 10 months ago (2016-02-12 02:05:14 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-12 03:29:33 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:41:18 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b4b1bdc22eabec57d57b92968a4fbf882446dfda
Cr-Commit-Position: refs/heads/master@{#375109}

Powered by Google App Engine
This is Rietveld 408576698