third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp - Issue 1696513002: DevTools: move protocol-related generators into inspector subfolder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp

Issue 1696513002: DevTools: move protocol-related generators into inspector subfolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/PromiseTracker.h ('k') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp b/third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp

index 4419e632088caad0266f4e6578a66984660903f4..04712fbeeb1c14e4209a63cb405685987051755b 100644

--- a/third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp

@@ -9,9 +9,9 @@

#include "wtf/CurrentTime.h"

#include "wtf/PassOwnPtr.h"

-using blink::TypeBuilder::Array;

-using blink::TypeBuilder::Runtime::CallFrame;

-using blink::TypeBuilder::Debugger::PromiseDetails;

+using blink::protocol::TypeBuilder::Array;

+using blink::protocol::TypeBuilder::Runtime::CallFrame;

+using blink::protocol::TypeBuilder::Debugger::PromiseDetails;

namespace blink {

@@ -25,7 +25,7 @@ public:

~PromiseWrapper()

{

RefPtr<PromiseDetails> promiseDetails = PromiseDetails::create().setId(m_id);

- m_tracker->m_agent->didUpdatePromise(InspectorFrontend::Debugger::EventType::Gc, promiseDetails.release());

+ m_tracker->m_agent->didUpdatePromise(protocol::Frontend::Debugger::EventType::Gc, promiseDetails.release());

}

private:

@@ -110,7 +110,7 @@ void PromiseTracker::didReceiveV8PromiseEvent(v8::Local<v8::Context> context, v8

bool isNewPromise = false;

int id = promiseId(promise, &isNewPromise);

- InspectorFrontend::Debugger::EventType::Enum eventType = isNewPromise ? InspectorFrontend::Debugger::EventType::New : InspectorFrontend::Debugger::EventType::Update;

+ protocol::Frontend::Debugger::EventType::Enum eventType = isNewPromise ? protocol::Frontend::Debugger::EventType::New : protocol::Frontend::Debugger::EventType::Update;

PromiseDetails::Status::Enum promiseStatus;

switch (status) {