third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h - Issue 1696513002: DevTools: move protocol-related generators into inspector subfolder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

Issue 1696513002: DevTools: move protocol-related generators into inspector subfolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorFrontendChannel.h ('k') | third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

index 501d434a65702f6f5347f5c6b552393584f893fb..84c1ef88191e0efe00301389f0b9f50dd0e4222e 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

@@ -32,7 +32,6 @@

#define InspectorHeapProfilerAgent_h

#include "core/CoreExport.h"

-#include "core/InspectorFrontend.h"

#include "core/inspector/InspectorBaseAgent.h"

#include "wtf/Forward.h"

#include "wtf/Noncopyable.h"

@@ -50,7 +49,7 @@ class V8RuntimeAgent;

typedef String ErrorString;

-class CORE_EXPORT InspectorHeapProfilerAgent final : public InspectorBaseAgent<InspectorHeapProfilerAgent, InspectorFrontend::HeapProfiler>, public InspectorBackendDispatcher::HeapProfilerCommandHandler {

+class CORE_EXPORT InspectorHeapProfilerAgent final : public InspectorBaseAgent<InspectorHeapProfilerAgent, protocol::Frontend::HeapProfiler>, public protocol::Dispatcher::HeapProfilerCommandHandler {

WTF_MAKE_NONCOPYABLE(InspectorHeapProfilerAgent);

USING_FAST_MALLOC_WILL_BE_REMOVED(InspectorHeapProfilerAgent);

public:

@@ -59,7 +58,7 @@ public:

// InspectorBaseAgent overrides.

void setState(PassRefPtr<JSONObject>) override;

- void setFrontend(InspectorFrontend*) override;

+ void setFrontend(protocol::Frontend*) override;

void clearFrontend() override;

void restore() override;

@@ -72,7 +71,7 @@ public:

void takeHeapSnapshot(ErrorString*, const bool* reportProgress) override;

- void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) override;

+ void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<protocol::TypeBuilder::Runtime::RemoteObject>& result) override;

void addInspectedHeapObject(ErrorString*, const String& inspectedHeapObjectId) override;

void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;