Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: filter/dscache/ds_txn_state.go

Issue 1695833002: dscache: Only log unusual memcache errors. (Closed) Base URL: https://github.com/luci/gae@master
Patch Set: inline. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « filter/dscache/ds.go ('k') | filter/dscache/support.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/dscache/ds_txn_state.go
diff --git a/filter/dscache/ds_txn_state.go b/filter/dscache/ds_txn_state.go
index 4497fcb99aa04720c4ece8d6f9eb56f01287b9c4..2176fe86227ea9adb0f3e2a949a5a30974fb7403 100644
--- a/filter/dscache/ds_txn_state.go
+++ b/filter/dscache/ds_txn_state.go
@@ -9,6 +9,7 @@ import (
"github.com/luci/gae/service/datastore"
"github.com/luci/gae/service/memcache"
+ "github.com/luci/luci-go/common/errors"
log "github.com/luci/luci-go/common/logging"
)
@@ -60,8 +61,7 @@ func (s *dsTxnState) release(sc *supportContext) {
delKeys = append(delKeys, k)
}
- err := sc.mc.DeleteMulti(delKeys)
- if err != nil {
+ if err := errors.Filter(sc.mc.DeleteMulti(delKeys), memcache.ErrCacheMiss); err != nil {
(log.Fields{log.ErrorKey: err}).Warningf(
sc.c, "dscache: txn.release: memcache.DeleteMulti")
}
« no previous file with comments | « filter/dscache/ds.go ('k') | filter/dscache/support.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698