Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: filter/dscache/ds.go

Issue 1695833002: dscache: Only log unusual memcache errors. (Closed) Base URL: https://github.com/luci/gae@master
Patch Set: inline. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | filter/dscache/ds_txn_state.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/dscache/ds.go
diff --git a/filter/dscache/ds.go b/filter/dscache/ds.go
index 542ada6b111cf2335a76602acdf94e10addec238..36a5eda685cf34d97f2f66a8ff99a0557e741abc 100644
--- a/filter/dscache/ds.go
+++ b/filter/dscache/ds.go
@@ -9,6 +9,7 @@ import (
ds "github.com/luci/gae/service/datastore"
"github.com/luci/gae/service/memcache"
+ "github.com/luci/luci-go/common/errors"
log "github.com/luci/luci-go/common/logging"
"golang.org/x/net/context"
)
@@ -44,7 +45,7 @@ func (d *dsCache) GetMulti(keys []*ds.Key, metas ds.MultiMetaGetter, cb ds.GetMu
// (so, not an issue), or because memcache is having sad times (in which
// case we'll see so in the GetMulti which immediately follows this).
}
- if err := d.mc.GetMulti(lockItems); err != nil {
+ if err := errors.Filter(d.mc.GetMulti(lockItems), memcache.ErrCacheMiss); err != nil {
(log.Fields{log.ErrorKey: err}).Warningf(
d.c, "dscache: GetMulti: memcache.GetMulti")
}
« no previous file with comments | « no previous file | filter/dscache/ds_txn_state.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698