Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: filter/dscache/support.go

Issue 1695833002: dscache: Only log unusual memcache errors. (Closed) Base URL: https://github.com/luci/gae@master
Patch Set: inline. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « filter/dscache/ds_txn_state.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: filter/dscache/support.go
diff --git a/filter/dscache/support.go b/filter/dscache/support.go
index 4a2480ab7d29162ff37510758d453a2767109e2c..a472a8ba64d1e0b784553c8151afb612bf93a34e 100644
--- a/filter/dscache/support.go
+++ b/filter/dscache/support.go
@@ -11,6 +11,7 @@ import (
ds "github.com/luci/gae/service/datastore"
"github.com/luci/gae/service/memcache"
+ "github.com/luci/luci-go/common/errors"
log "github.com/luci/luci-go/common/logging"
"golang.org/x/net/context"
)
@@ -117,7 +118,7 @@ func (s *supportContext) mutation(keys []*ds.Key, f func() error) error {
}
err := f()
if err == nil {
- if err := s.mc.DeleteMulti(lockKeys); err != nil {
+ if err := errors.Filter(s.mc.DeleteMulti(lockKeys), memcache.ErrCacheMiss); err != nil {
(log.Fields{log.ErrorKey: err}).Warningf(
s.c, "dscache: mc.DeleteMulti")
}
« no previous file with comments | « filter/dscache/ds_txn_state.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698