Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1695833002: dscache: Only log unusual memcache errors. (Closed)

Created:
4 years, 10 months ago by dnj
Modified:
4 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

dscache: Only log unusual memcache errors. BUG=None TEST=None R=iannucci@chromium.org Committed: https://github.com/luci/gae/commit/ccd7f43dada792cce1ec7b05c68a82f164dbbbb1

Patch Set 1 #

Patch Set 2 : Rewrite with errors.Filter #

Total comments: 1

Patch Set 3 : inline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M filter/dscache/ds.go View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M filter/dscache/ds_txn_state.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M filter/dscache/support.go View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dnj
4 years, 10 months ago (2016-02-12 20:00:04 UTC) #1
iannucci
https://chromiumcodereview.appspot.com/1695833002/diff/20001/filter/dscache/ds.go File filter/dscache/ds.go (right): https://chromiumcodereview.appspot.com/1695833002/diff/20001/filter/dscache/ds.go#newcode151 filter/dscache/ds.go:151: func filterMCErr(err error) error { inline this sucka!
4 years, 10 months ago (2016-02-13 00:16:44 UTC) #2
iannucci
lgtm
4 years, 10 months ago (2016-02-13 00:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695833002/40001
4 years, 10 months ago (2016-02-17 22:53:21 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:56:57 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/ccd7f43dada792cce1ec7b05c68a82f164dbbbb1

Powered by Google App Engine
This is Rietveld 408576698