Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1695773002: Resynthesize positional/named parameters as DefaultParameterElementImpl. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize positional/named parameters as DefaultParameterElementImpl. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1f5f2bc14f15a729b0ccb3848c7f0c69daff2115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-12 16:47:32 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-02-12 16:55:10 UTC) #2
scheglov
4 years, 10 months ago (2016-02-12 16:57:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f5f2bc14f15a729b0ccb3848c7f0c69daff2115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698