Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1695773002: Resynthesize positional/named parameters as DefaultParameterElementImpl. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/resynthesize.dart
diff --git a/pkg/analyzer/lib/src/summary/resynthesize.dart b/pkg/analyzer/lib/src/summary/resynthesize.dart
index 8e55bd8cc9e6f5b5255fe2bafa75a70c39eafab1..0ca1f06f236299d37a4cab2557b1f29dcbc8169e 100644
--- a/pkg/analyzer/lib/src/summary/resynthesize.dart
+++ b/pkg/analyzer/lib/src/summary/resynthesize.dart
@@ -1478,16 +1478,18 @@ class _LibraryResynthesizer {
parameterElement = initializingParameter;
initializingParameter.field = fields[serializedParameter.name];
} else {
- if (serializedParameter.defaultValue != null) {
+ if (serializedParameter.kind == UnlinkedParamKind.required) {
+ parameterElement = new ParameterElementImpl(
+ serializedParameter.name, serializedParameter.nameOffset);
+ } else {
DefaultParameterElementImpl defaultParameter =
new DefaultParameterElementImpl(
serializedParameter.name, serializedParameter.nameOffset);
parameterElement = defaultParameter;
- defaultParameter.constantInitializer =
- _buildConstExpression(serializedParameter.defaultValue);
- } else {
- parameterElement = new ParameterElementImpl(
- serializedParameter.name, serializedParameter.nameOffset);
+ if (serializedParameter.defaultValue != null) {
+ defaultParameter.constantInitializer =
+ _buildConstExpression(serializedParameter.defaultValue);
+ }
}
}
buildAnnotations(parameterElement, serializedParameter.annotations);
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698