Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1695773002: Resynthesize positional/named parameters as DefaultParameterElementImpl. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library summary_resynthesizer; 5 library summary_resynthesizer;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/element/element.dart'; 10 import 'package:analyzer/dart/element/element.dart';
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1471 initializingParameter = defaultParameter; 1471 initializingParameter = defaultParameter;
1472 defaultParameter.constantInitializer = 1472 defaultParameter.constantInitializer =
1473 _buildConstExpression(serializedParameter.defaultValue); 1473 _buildConstExpression(serializedParameter.defaultValue);
1474 } else { 1474 } else {
1475 initializingParameter = new FieldFormalParameterElementImpl( 1475 initializingParameter = new FieldFormalParameterElementImpl(
1476 serializedParameter.name, serializedParameter.nameOffset); 1476 serializedParameter.name, serializedParameter.nameOffset);
1477 } 1477 }
1478 parameterElement = initializingParameter; 1478 parameterElement = initializingParameter;
1479 initializingParameter.field = fields[serializedParameter.name]; 1479 initializingParameter.field = fields[serializedParameter.name];
1480 } else { 1480 } else {
1481 if (serializedParameter.defaultValue != null) { 1481 if (serializedParameter.kind == UnlinkedParamKind.required) {
1482 parameterElement = new ParameterElementImpl(
1483 serializedParameter.name, serializedParameter.nameOffset);
1484 } else {
1482 DefaultParameterElementImpl defaultParameter = 1485 DefaultParameterElementImpl defaultParameter =
1483 new DefaultParameterElementImpl( 1486 new DefaultParameterElementImpl(
1484 serializedParameter.name, serializedParameter.nameOffset); 1487 serializedParameter.name, serializedParameter.nameOffset);
1485 parameterElement = defaultParameter; 1488 parameterElement = defaultParameter;
1486 defaultParameter.constantInitializer = 1489 if (serializedParameter.defaultValue != null) {
1487 _buildConstExpression(serializedParameter.defaultValue); 1490 defaultParameter.constantInitializer =
1488 } else { 1491 _buildConstExpression(serializedParameter.defaultValue);
1489 parameterElement = new ParameterElementImpl( 1492 }
1490 serializedParameter.name, serializedParameter.nameOffset);
1491 } 1493 }
1492 } 1494 }
1493 buildAnnotations(parameterElement, serializedParameter.annotations); 1495 buildAnnotations(parameterElement, serializedParameter.annotations);
1494 if (serializedParameter.isFunctionTyped) { 1496 if (serializedParameter.isFunctionTyped) {
1495 FunctionElementImpl parameterTypeElement = 1497 FunctionElementImpl parameterTypeElement =
1496 new FunctionElementImpl('', -1); 1498 new FunctionElementImpl('', -1);
1497 parameterTypeElement.synthetic = true; 1499 parameterTypeElement.synthetic = true;
1498 parameterElement.parameters = 1500 parameterElement.parameters =
1499 serializedParameter.parameters.map(buildParameter).toList(); 1501 serializedParameter.parameters.map(buildParameter).toList();
1500 parameterTypeElement.enclosingElement = parameterElement; 1502 parameterTypeElement.enclosingElement = parameterElement;
(...skipping 614 matching lines...) Expand 10 before | Expand all | Expand 10 after
2115 } 2117 }
2116 : () => this.element; 2118 : () => this.element;
2117 // TODO(paulberry): Is it a bug that we have to pass `false` for 2119 // TODO(paulberry): Is it a bug that we have to pass `false` for
2118 // isInstantiated? 2120 // isInstantiated?
2119 return new DeferredFunctionTypeImpl(computer, null, typeArguments, false); 2121 return new DeferredFunctionTypeImpl(computer, null, typeArguments, false);
2120 } else { 2122 } else {
2121 return null; 2123 return null;
2122 } 2124 }
2123 } 2125 }
2124 } 2126 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698