[builtins] Support SameValue and SameValueZero via runtime functions.

[builtins] Support SameValue and SameValueZero via runtime functions.

Also move Object.is implementation to C++ builtin, which is faster
than the current implementation.

R=mstarzinger@chromium.org

Committed: https://crrev.com/1e79bd5cc807647e6708705d123b0a713839b212
Cr-Commit-Position: refs/heads/master@{#34069}

[Benedikt Meurer, 2016-02-12 14:01:47]

Hey Michi,

Another easy cleanup.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2016-02-17 09:44:21]

LGTM.

https://codereview.chromium.org/1695743003/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1695743003/diff/1/src/builtins.cc#newcode1810
src/builtins.cc:1810: Object* value1 = args[1];
nit: Even with the sealed handle scope, we should still be able to write this
code handlified (slots in the "args" object are implicit handles). I think that
would make it safer ...

  Handle<Object> value1 = args.at<Object>(1);

https://codereview.chromium.org/1695743003/diff/1/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1695743003/diff/1/src/js/v8natives.js#newcode868
src/js/v8natives.js:868: // keys is added in bootstrapper.cc.
nit: Can we add a comment here saying that "is is added in bootstrapper.cc." as
well?

https://codereview.chromium.org/1695743003/diff/1/test/mjsunit/samevalue.js
File test/mjsunit/samevalue.js (right):

https://codereview.chromium.org/1695743003/diff/1/test/mjsunit/samevalue.js#n...
test/mjsunit/samevalue.js:36: var sameValueZero = function(x, y) { return
%SameValue(x, y); }
Shouldn't this be %SameValueZero here?

[Benedikt Meurer (Google), 2016-02-17 10:16:06]

The CQ bit was checked by bmeurer@google.com

[Benedikt Meurer (Google), 2016-02-17 10:16:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1695743003/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-02-17 10:16:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695743003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695743003/40001

[Benedikt Meurer (Google), 2016-02-17 10:16:22]

The CQ bit was unchecked by bmeurer@google.com

[Benedikt Meurer, 2016-02-17 10:20:26]

https://codereview.chromium.org/1695743003/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1695743003/diff/1/src/builtins.cc#newcode1810
src/builtins.cc:1810: Object* value1 = args[1];
On 2016/02/17 09:44:21, Michael Starzinger wrote:
> nit: Even with the sealed handle scope, we should still be able to write this
> code handlified (slots in the "args" object are implicit handles). I think
that
> would make it safer ...
> 
>   Handle<Object> value1 = args.at<Object>(1);

Done.

https://codereview.chromium.org/1695743003/diff/1/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1695743003/diff/1/src/js/v8natives.js#newcode868
src/js/v8natives.js:868: // keys is added in bootstrapper.cc.
On 2016/02/17 09:44:21, Michael Starzinger wrote:
> nit: Can we add a comment here saying that "is is added in bootstrapper.cc."
as
> well?

Done.

https://codereview.chromium.org/1695743003/diff/1/test/mjsunit/samevalue.js
File test/mjsunit/samevalue.js (right):

https://codereview.chromium.org/1695743003/diff/1/test/mjsunit/samevalue.js#n...
test/mjsunit/samevalue.js:36: var sameValueZero = function(x, y) { return
%SameValue(x, y); }
On 2016/02/17 09:44:21, Michael Starzinger wrote:
> Shouldn't this be %SameValueZero here?

Done.

[Benedikt Meurer, 2016-02-17 10:31:43]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-02-17 10:31:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1695743003/#ps60001
(title: "Address bug in SameValue and SameValueZero for SIMD types.")

[commit-bot: I haz the power, 2016-02-17 10:32:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695743003/60001

[commit-bot: I haz the power, 2016-02-17 10:54:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-17 10:54:30]

Description was changed from

==========
[builtins] Support SameValue and SameValueZero via runtime functions.

Also move Object.is implementation to C++ builtin, which is faster
than the current implementation.

R=mstarzinger@chromium.org
==========

to

==========
[builtins] Support SameValue and SameValueZero via runtime functions.

Also move Object.is implementation to C++ builtin, which is faster
than the current implementation.

R=mstarzinger@chromium.org

Committed: https://crrev.com/1e79bd5cc807647e6708705d123b0a713839b212
Cr-Commit-Position: refs/heads/master@{#34069}
==========

[commit-bot: I haz the power, 2016-02-17 10:54:31]

Patchset 4 (id:??) landed as
https://crrev.com/1e79bd5cc807647e6708705d123b0a713839b212
Cr-Commit-Position: refs/heads/master@{#34069}