test/mjsunit/harmony/simd.js - Issue 1695743003: [builtins] Support SameValue and SameValueZero via runtime functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/harmony/simd.js

Issue 1695743003: [builtins] Support SameValue and SameValueZero via runtime functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address bug in SameValue and SameValueZero for SIMD types. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/harmony/simd.js

diff --git a/test/mjsunit/harmony/simd.js b/test/mjsunit/harmony/simd.js

index 6330ac8338a403a014b5a5076dd0eff232f296d8..ff81506afe8cd81645bb26df4e6c10b008f768f9 100644

--- a/test/mjsunit/harmony/simd.js

+++ b/test/mjsunit/harmony/simd.js

@@ -407,7 +407,7 @@ function TestSameValue(type, lanes) {

var simdFn = SIMD[type];

var instance = createInstance(type);

var sameValue = Object.is

- var sameValueZero = natives.ImportNow("SameValueZero");

+ var sameValueZero = function(x, y) { return %SameValueZero(x, y); }

// SIMD values should not be the same as instances of different types.

checkTypeMatrix(type, function(other) {

« no previous file with comments | « src/runtime/runtime-simd.cc ('k') | test/mjsunit/samevalue.js » ('j') | no next file with comments »