src/runtime/runtime.h - Issue 1695743003: [builtins] Support SameValue and SameValueZero via runtime functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime.h

Issue 1695743003: [builtins] Support SameValue and SameValueZero via runtime functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address bug in SameValue and SameValueZero for SIMD types. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime.h

diff --git a/src/runtime/runtime.h b/src/runtime/runtime.h

index ca90b2fab0d215cafe5037a6704f31a0dbcbcf2c..9104749bb94b8f7d3eb45f063542f3e15e27f434 100644

--- a/src/runtime/runtime.h

+++ b/src/runtime/runtime.h

@@ -467,6 +467,8 @@ namespace internal {

F(ToName, 1, 1) \

F(Equals, 2, 1) \

F(StrictEquals, 2, 1) \

+ F(SameValue, 2, 1) \

+ F(SameValueZero, 2, 1) \

F(Compare, 3, 1) \

F(InstanceOf, 2, 1) \

F(HasInPrototypeChain, 2, 1) \

@@ -550,8 +552,6 @@ namespace internal {

#define FOR_EACH_INTRINSIC_SIMD(F) \

F(IsSimdValue, 1, 1) \

- F(SimdSameValue, 2, 1) \

- F(SimdSameValueZero, 2, 1) \

F(CreateFloat32x4, 4, 1) \

F(CreateInt32x4, 4, 1) \

F(CreateUint32x4, 4, 1) \

« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »