Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1695673004: Exposes <hr> elements that do not have an ARIA label. (Closed)

Created:
4 years, 10 months ago by nektarios
Modified:
4 years, 10 months ago
Reviewers:
je_julie, dmazzoni
CC:
nektarios, aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exposes <hr> elements that do not have an ARIA label. BUG=384723 R=dmazzoni@chromium.org TESTED=browser tests, using Jaws Committed: https://crrev.com/05422fee4da7ba01c6f4a93d917a6538befa903e Cr-Commit-Position: refs/heads/master@{#376055}

Patch Set 1 #

Patch Set 2 : DFixd patch conflict. #

Patch Set 3 : Fixed Android test. #

Patch Set 4 : Fixed Windows tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M content/test/data/accessibility/html/hr.html View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/hr-expected-android.txt View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/hr-expected-mac.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/hr-expected-win.txt View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
nektarios
4 years, 10 months ago (2016-02-12 23:18:37 UTC) #1
dmazzoni
lgtm
4 years, 10 months ago (2016-02-12 23:59:26 UTC) #2
nektarios
+je_julie who I think implemented the initial support for splitters.
4 years, 10 months ago (2016-02-13 01:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695673004/1
4 years, 10 months ago (2016-02-16 20:47:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/125862) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-16 20:51:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695673004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695673004/20001
4 years, 10 months ago (2016-02-16 22:19:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/23957)
4 years, 10 months ago (2016-02-16 23:42:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695673004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695673004/40001
4 years, 10 months ago (2016-02-17 02:07:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/167522)
4 years, 10 months ago (2016-02-17 03:22:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695673004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695673004/40001
4 years, 10 months ago (2016-02-17 19:37:48 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/175146)
4 years, 10 months ago (2016-02-17 21:08:19 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695673004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695673004/60001
4 years, 10 months ago (2016-02-17 22:43:29 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 23:39:51 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695673004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695673004/60001
4 years, 10 months ago (2016-02-18 01:13:28 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-18 01:22:16 UTC) #30
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 01:23:37 UTC) #32
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/05422fee4da7ba01c6f4a93d917a6538befa903e
Cr-Commit-Position: refs/heads/master@{#376055}

Powered by Google App Engine
This is Rietveld 408576698