Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 1695673004: Exposes <hr> elements that do not have an ARIA label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Windows tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/data/accessibility/html/hr-expected-win.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 663
664 if (roleValue() == FigcaptionRole) 664 if (roleValue() == FigcaptionRole)
665 return false; 665 return false;
666 666
667 if (roleValue() == FigureRole) 667 if (roleValue() == FigureRole)
668 return false; 668 return false;
669 669
670 if (roleValue() == DetailsRole) 670 if (roleValue() == DetailsRole)
671 return false; 671 return false;
672 672
673 if (roleValue() == MarkRole)
674 return false;
675
673 if (roleValue() == MathRole) 676 if (roleValue() == MathRole)
674 return false; 677 return false;
675 678
676 if (roleValue() == MeterRole) 679 if (roleValue() == MeterRole)
677 return false; 680 return false;
678 681
679 if (roleValue() == RubyRole) 682 if (roleValue() == RubyRole)
680 return false; 683 return false;
681 684
685 if (roleValue() == SplitterRole)
686 return false;
687
682 if (roleValue() == TimeRole) 688 if (roleValue() == TimeRole)
683 return false; 689 return false;
684 690
685 if (roleValue() == MarkRole)
686 return false;
687
688 // if this element has aria attributes on it, it should not be ignored. 691 // if this element has aria attributes on it, it should not be ignored.
689 if (supportsARIAAttributes()) 692 if (supportsARIAAttributes())
690 return false; 693 return false;
691 694
692 // <span> tags are inline tags and not meant to convey information if they h ave no other aria 695 // <span> tags are inline tags and not meant to convey information if they h ave no other aria
693 // information on them. If we don't ignore them, they may emit signals expec ted to come from 696 // information on them. If we don't ignore them, they may emit signals expec ted to come from
694 // their parent. In addition, because included spans are GroupRole objects, and GroupRole 697 // their parent. In addition, because included spans are GroupRole objects, and GroupRole
695 // objects are often containers with meaningful information, the inclusion o f a span can have 698 // objects are often containers with meaningful information, the inclusion o f a span can have
696 // the side effect of causing the immediate parent accessible to be ignored. This is especially 699 // the side effect of causing the immediate parent accessible to be ignored. This is especially
697 // problematic for platforms which have distinct roles for textual block ele ments. 700 // problematic for platforms which have distinct roles for textual block ele ments.
(...skipping 1837 matching lines...) Expand 10 before | Expand all | Expand 10 after
2535 if (label && label->layoutObject()) { 2538 if (label && label->layoutObject()) {
2536 LayoutRect labelRect = axObjectCache().getOrCreate(label)->elementRe ct(); 2539 LayoutRect labelRect = axObjectCache().getOrCreate(label)->elementRe ct();
2537 result.unite(labelRect); 2540 result.unite(labelRect);
2538 } 2541 }
2539 } 2542 }
2540 2543
2541 return result; 2544 return result;
2542 } 2545 }
2543 2546
2544 } // namespace blink 2547 } // namespace blink
OLDNEW
« no previous file with comments | « content/test/data/accessibility/html/hr-expected-win.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698