Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 1695673004: Exposes <hr> elements that do not have an ARIA label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Windows tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/data/accessibility/html/hr-expected-win.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
index 5aaa287b9f6335f975cb79aa1a0d201bc3452dac..02d3e1a27524aa6a4b910eacb3c805f9c73f7de0 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -670,6 +670,9 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReason
if (roleValue() == DetailsRole)
return false;
+ if (roleValue() == MarkRole)
+ return false;
+
if (roleValue() == MathRole)
return false;
@@ -679,10 +682,10 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReason
if (roleValue() == RubyRole)
return false;
- if (roleValue() == TimeRole)
+ if (roleValue() == SplitterRole)
return false;
- if (roleValue() == MarkRole)
+ if (roleValue() == TimeRole)
return false;
// if this element has aria attributes on it, it should not be ignored.
« no previous file with comments | « content/test/data/accessibility/html/hr-expected-win.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698