Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1695653002: Take Accept-Language into account in CJK font fallback for Windows (Closed)

Created:
4 years, 10 months ago by kojii
Modified:
4 years, 10 months ago
Reviewers:
drott
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@al
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Take Accept-Language into account in CJK font fallback for Windows This patch changes the CJK font fallback for Windows when neither the content (the lang attribute) nor the UI locale can disambiguate the Unified Han script. The first entry in the Accept-Language user preference that can disambiguate the Han script is taken into account. BUG=411407

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M third_party/WebKit/Source/platform/fonts/FontCache.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 2 chunks +20 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 2 chunks +16 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
kojii
PTAL.
4 years, 10 months ago (2016-02-12 07:04:24 UTC) #3
drott
I guess this is superceded by https://codereview.chromium.org/1693563003/?
4 years, 10 months ago (2016-02-12 11:24:03 UTC) #4
drott
Sorry, forget my comment, I didn't see the difference Android/Windows.
4 years, 10 months ago (2016-02-12 11:25:33 UTC) #5
kojii
4 years, 10 months ago (2016-02-12 17:04:23 UTC) #6
Merging to the Android's CL at https://codereview.chromium.org/1693563003

Powered by Google App Engine
This is Rietveld 408576698