Add FontCache::acceptLanguagesChanged()

Add FontCache::acceptLanguagesChanged()

In preparaiton of using Accept-Language user preference for the font
fallback to resolve ambiguities, this patch adds
FontCache::acceptLanguagesChanged().

RenderViewImpl::OnSetRendererPrefs() calls
WebView::acceptLanguagesChanged(), which covers both the initialization
and when the setting was changed.

The optimal way to handle it varies by platform. This patch adds empty
bodies to all platforms, which will be filled in future.

Minor left over in FontFallbackWin.h in the last CL is also removed.

BUG=411407
Committed: https://crrev.com/0289cad37b121f25b7d59566912a5270ade01c96
Cr-Commit-Position: refs/heads/master@{#375134}

[kojii, 2016-02-11 15:53:42]

Description was changed from

==========
WIP: Support accept-languages in font fallback

BUG=
==========

to

==========
Add accept-languages to CJK font fallback for Windows

This patch takes accept-languages preferences into account for CJK font
fallback on Windows.

To do so, WebViewImpl calls FontCache::acceptLanguagesChanged(), which
is implemented for each platform since the optimal way to compute when
accept-languages are changed differ by platform. This patch adds the
logic for Windows, and other platforms have empty bodies to be filled
in future.

Minor left over in FontFallbackWin.h in the last CL is also removed.

BUG=411407
==========

[kojii, 2016-02-11 18:26:26]

kojii@chromium.org changed reviewers:
+ drott@chromium.org

[kojii, 2016-02-11 18:26:26]

drott@, PTAL for platform/fonts. I'll then ask other reviewer for web.

[kojii, 2016-02-12 03:20:53]

Description was changed from

==========
Add accept-languages to CJK font fallback for Windows

This patch takes accept-languages preferences into account for CJK font
fallback on Windows.

To do so, WebViewImpl calls FontCache::acceptLanguagesChanged(), which
is implemented for each platform since the optimal way to compute when
accept-languages are changed differ by platform. This patch adds the
logic for Windows, and other platforms have empty bodies to be filled
in future.

Minor left over in FontFallbackWin.h in the last CL is also removed.

BUG=411407
==========

to

==========
Add FontCache::acceptLanguagesChanged()

In preparaiton of using Accept-Language user preference for the font
fallback to resolve ambiguities, this patch adds
FontCache::acceptLanguagesChanged().

RenderViewImpl::OnSetRendererPrefs() calls
WebView::acceptLanguagesChanged(), which covers both the initialization
and when the setting was changed.

The optimal way to handle it varies by platform. This patch adds empty
bodies to all platforms, which will be filled in future.

Minor left over in FontFallbackWin.h in the last CL is also removed.

BUG=411407
==========

[kojii, 2016-02-12 03:46:26]

kojii@chromium.org changed reviewers:
+ tkent@chromium.org
- drott@chromium.org

[kojii, 2016-02-12 03:46:27]

tkent@, PTAL. If you can review both web and platform, that's superb. Otherwise
I'll ask someone else for platform.

Platform-dependent logic are split into separate patches, I'll ask font experts
to review them.

[kojii, 2016-02-12 03:47:36]

Forgot to note that android bot is claiming that "Source/platform/fonts"
directory is missing. Hopefully bots should be fixed.

[tkent, 2016-02-12 04:01:20]

https://codereview.chromium.org/1682103004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp
(right):

https://codereview.chromium.org/1682103004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp:60: void
FontCache::acceptLanguagesChanged(const String&)
Style nit:  This should be

void ...() {}

or

void ...()
{
}

Also, because you'll add code here, you should do

void ...()
{
    // TODO(kojii): ...
}

[kojii, 2016-02-12 04:33:47]

PTAL.

https://codereview.chromium.org/1682103004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp
(right):

https://codereview.chromium.org/1682103004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp:60: void
FontCache::acceptLanguagesChanged(const String&)
On 2016/02/12 at 04:01:19, tkent wrote:
> Style nit:  This should be
> 
> void ...() {}
> 
> or
> 
> void ...()
> {
> }
> 
> Also, because you'll add code here, you should do
> 
> void ...()
> {
>     // TODO(kojii): ...
> }

Done, add TODO for planned platforms (win/android) and empty for the rest.

[tkent, 2016-02-12 04:37:03]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-02-12 04:37:03]

lgtm

[commit-bot: I haz the power, 2016-02-12 04:38:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682103004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682103004/120001

[commit-bot: I haz the power, 2016-02-12 06:00:56]

Committed patchset #7 (id:120001)

[drott, 2016-02-12 11:28:11]

> The optimal way to handle it varies by platform. This patch adds empty
> bodies to all platforms, which will be filled in future.

Could you explain why this is the case? I'd rather develop into a direction
where we have less code in the platform specific implementations of FontCache.

[kojii, 2016-02-12 11:54:37]

On 2016/02/12 at 11:28:11, drott wrote:
> > The optimal way to handle it varies by platform. This patch adds empty
> > bodies to all platforms, which will be filled in future.
> 
> Could you explain why this is the case? I'd rather develop into a direction
where we have less code in the platform specific implementations of FontCache.

Currently Windows uses USCRIPT_* while Skia has const char* locale, so we need
the same logic but to store differently.

I prefer USCRIPT_*, which I believe is (a minor but) perf win, but it's hard to
change Skia, no?

[kojii, 2016-02-12 12:25:53]

One more difference; we hear complaints only from Win, Linux, and Android. No
complaints for Mac, so Mac is likely to be an empty. Linux has issues but it
needs more study on font-config, so I expect it to happen much later.

[commit-bot: I haz the power, 2016-02-16 22:41:58]

Description was changed from

==========
Add FontCache::acceptLanguagesChanged()

In preparaiton of using Accept-Language user preference for the font
fallback to resolve ambiguities, this patch adds
FontCache::acceptLanguagesChanged().

RenderViewImpl::OnSetRendererPrefs() calls
WebView::acceptLanguagesChanged(), which covers both the initialization
and when the setting was changed.

The optimal way to handle it varies by platform. This patch adds empty
bodies to all platforms, which will be filled in future.

Minor left over in FontFallbackWin.h in the last CL is also removed.

BUG=411407
==========

to

==========
Add FontCache::acceptLanguagesChanged()

In preparaiton of using Accept-Language user preference for the font
fallback to resolve ambiguities, this patch adds
FontCache::acceptLanguagesChanged().

RenderViewImpl::OnSetRendererPrefs() calls
WebView::acceptLanguagesChanged(), which covers both the initialization
and when the setting was changed.

The optimal way to handle it varies by platform. This patch adds empty
bodies to all platforms, which will be filled in future.

Minor left over in FontFallbackWin.h in the last CL is also removed.

BUG=411407

Committed: https://crrev.com/0289cad37b121f25b7d59566912a5270ade01c96
Cr-Commit-Position: refs/heads/master@{#375134}
==========

[commit-bot: I haz the power, 2016-02-16 22:41:59]

Patchset 7 (id:??) landed as
https://crrev.com/0289cad37b121f25b7d59566912a5270ade01c96
Cr-Commit-Position: refs/heads/master@{#375134}