Handlify DeoptimizedFrameInfo, remove custom GC iteration.

Handlify DeoptimizedFrameInfo, remove custom GC iteration.

TBR=mstarzinger@chromium.org

Committed: https://crrev.com/c0198937d8a2a78b358fe6096e35a245d26b3a37
Cr-Commit-Position: refs/heads/master@{#33926}

[Jarin, 2016-02-11 15:09:17]

jarin@chromium.org changed reviewers:
+ yangguo@chromium.org

[Jarin, 2016-02-11 15:09:18]

Could you take a look, please?

[Jarin, 2016-02-12 05:08:09]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-02-12 05:14:52]

I love it! LGTM!

https://codereview.chromium.org/1695433002/diff/20001/src/debug/debug-frames.cc
File src/debug/debug-frames.cc (right):

https://codereview.chromium.org/1695433002/diff/20001/src/debug/debug-frames....
src/debug/debug-frames.cc:49: : Handle<JSFunction>(frame_->function(),
isolate_);
Nit: Use handle() instead.

https://codereview.chromium.org/1695433002/diff/20001/src/debug/debug-frames....
src/debug/debug-frames.cc:54: : Handle<Object>(frame_->GetParameter(index),
isolate_);
Nit: Use handle() instead.

https://codereview.chromium.org/1695433002/diff/20001/src/debug/debug-frames....
src/debug/debug-frames.cc:65: : Handle<Object>(frame_->GetExpression(index),
isolate_);
See above.

[Jarin, 2016-02-12 05:16:56]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-02-12 05:16:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1695433002/#ps40001
(title: "Use handle rather than the constructor.")

[commit-bot: I haz the power, 2016-02-12 05:17:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695433002/40001

[commit-bot: I haz the power, 2016-02-12 05:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 05:21:06]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10859)

[Yang, 2016-02-12 05:23:36]

awesome! lgtm. you will need a heap owner though.

https://codereview.chromium.org/1695433002/diff/20001/src/debug/debug-frames.cc
File src/debug/debug-frames.cc (right):

https://codereview.chromium.org/1695433002/diff/20001/src/debug/debug-frames....
src/debug/debug-frames.cc:54: : Handle<Object>(frame_->GetParameter(index),
isolate_);
On 2016/02/12 05:14:52, Benedikt Meurer wrote:
> Nit: Use handle() instead.

doesnt work on Object since you cant get isolate from it. You get fewer
instructions if you explictly provide the isolate, so I guess either is fine.

[Jarin, 2016-02-12 05:31:27]

Description was changed from

==========
Handlify DeoptimizedFrameInfo, remove custom GC iteration.
==========

to

==========
Handlify DeoptimizedFrameInfo, remove custom GC iteration.

TBR=mstarzinger@chromium.org
==========

[Jarin, 2016-02-12 05:31:38]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2016-02-12 05:31:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695433002/40001

[commit-bot: I haz the power, 2016-02-12 05:49:52]

Description was changed from

==========
Handlify DeoptimizedFrameInfo, remove custom GC iteration.

TBR=mstarzinger@chromium.org
==========

to

==========
Handlify DeoptimizedFrameInfo, remove custom GC iteration.

TBR=mstarzinger@chromium.org
==========

[commit-bot: I haz the power, 2016-02-12 05:49:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-12 05:50:34]

Description was changed from

==========
Handlify DeoptimizedFrameInfo, remove custom GC iteration.

TBR=mstarzinger@chromium.org
==========

to

==========
Handlify DeoptimizedFrameInfo, remove custom GC iteration.

TBR=mstarzinger@chromium.org

Committed: https://crrev.com/c0198937d8a2a78b358fe6096e35a245d26b3a37
Cr-Commit-Position: refs/heads/master@{#33926}
==========

[commit-bot: I haz the power, 2016-02-12 05:50:35]

Patchset 3 (id:??) landed as
https://crrev.com/c0198937d8a2a78b358fe6096e35a245d26b3a37
Cr-Commit-Position: refs/heads/master@{#33926}