Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/debug/debug-scopes.h

Issue 1695433002: Handlify DeoptimizedFrameInfo, remove custom GC iteration. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use handle rather than the constructor. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug-frames.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_SCOPES_H_ 5 #ifndef V8_DEBUG_DEBUG_SCOPES_H_
6 #define V8_DEBUG_DEBUG_SCOPES_H_ 6 #define V8_DEBUG_DEBUG_SCOPES_H_
7 7
8 #include "src/debug/debug-frames.h" 8 #include "src/debug/debug-frames.h"
9 #include "src/frames.h" 9 #include "src/frames.h"
10 10
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 List<Handle<ScopeInfo> > nested_scope_chain_; 89 List<Handle<ScopeInfo> > nested_scope_chain_;
90 HashMap* non_locals_; 90 HashMap* non_locals_;
91 bool seen_script_scope_; 91 bool seen_script_scope_;
92 bool failed_; 92 bool failed_;
93 93
94 inline JavaScriptFrame* GetFrame() { 94 inline JavaScriptFrame* GetFrame() {
95 return frame_inspector_->GetArgumentsFrame(); 95 return frame_inspector_->GetArgumentsFrame();
96 } 96 }
97 97
98 inline Handle<JSFunction> GetFunction() { 98 inline Handle<JSFunction> GetFunction() {
99 return Handle<JSFunction>( 99 return Handle<JSFunction>::cast(frame_inspector_->GetFunction());
100 JSFunction::cast(frame_inspector_->GetFunction()));
101 } 100 }
102 101
103 static bool InternalizedStringMatch(void* key1, void* key2) { 102 static bool InternalizedStringMatch(void* key1, void* key2) {
104 Handle<String> s1(reinterpret_cast<String**>(key1)); 103 Handle<String> s1(reinterpret_cast<String**>(key1));
105 Handle<String> s2(reinterpret_cast<String**>(key2)); 104 Handle<String> s2(reinterpret_cast<String**>(key2));
106 DCHECK(s1->IsInternalizedString()); 105 DCHECK(s1->IsInternalizedString());
107 DCHECK(s2->IsInternalizedString()); 106 DCHECK(s2->IsInternalizedString());
108 return s1.is_identical_to(s2); 107 return s1.is_identical_to(s2);
109 } 108 }
110 109
(...skipping 30 matching lines...) Expand all
141 Handle<JSObject> scope_object, 140 Handle<JSObject> scope_object,
142 KeyCollectionType type); 141 KeyCollectionType type);
143 142
144 DISALLOW_IMPLICIT_CONSTRUCTORS(ScopeIterator); 143 DISALLOW_IMPLICIT_CONSTRUCTORS(ScopeIterator);
145 }; 144 };
146 145
147 } // namespace internal 146 } // namespace internal
148 } // namespace v8 147 } // namespace v8
149 148
150 #endif // V8_DEBUG_DEBUG_SCOPES_H_ 149 #endif // V8_DEBUG_DEBUG_SCOPES_H_
OLDNEW
« no previous file with comments | « src/debug/debug-frames.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698