src/debug/debug-frames.h - Issue 1695433002: Handlify DeoptimizedFrameInfo, remove custom GC iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-frames.h

Issue 1695433002: Handlify DeoptimizedFrameInfo, remove custom GC iteration. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use handle rather than the constructor. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug-frames.h

diff --git a/src/debug/debug-frames.h b/src/debug/debug-frames.h

index c0d20bbd1d1f45a2b443d74589ec642ddf4b627c..c938f67f313d56ab2f180ab649434a1181bef677 100644

--- a/src/debug/debug-frames.h

+++ b/src/debug/debug-frames.h

@@ -21,12 +21,12 @@ class FrameInspector {

~FrameInspector();

int GetParametersCount();

- Object* GetFunction();

- Object* GetParameter(int index);

- Object* GetExpression(int index);

+ Handle<Object> GetFunction();

+ Handle<Object> GetParameter(int index);

+ Handle<Object> GetExpression(int index);

int GetSourcePosition();

bool IsConstructor();

- Object* GetContext();

+ Handle<Object> GetContext();

JavaScriptFrame* GetArgumentsFrame() { return frame_; }

void SetArgumentsFrame(JavaScriptFrame* frame);

« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | src/debug/debug-frames.cc » ('j') | no next file with comments »