Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3217)

Unified Diff: chrome/android/java/res/layout/toolbar.xml

Issue 1694673002: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from second self-review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/toolbar.xml
diff --git a/chrome/android/java/res/layout/toolbar.xml b/chrome/android/java/res/layout/toolbar.xml
index 2aa1e637cc20b31fb747bb0c12874431d39dd3df..df23cb20d3b7d70d6fc4bcb3de84800dfcdb6b44 100644
--- a/chrome/android/java/res/layout/toolbar.xml
+++ b/chrome/android/java/res/layout/toolbar.xml
@@ -76,9 +76,12 @@
<ImageView
android:id="@+id/menu_badge"
style="@style/UpdateMenuBadge"
- android:src="@drawable/badge_update"
- android:layout_marginEnd="8.5dp"
- android:contentDescription="@null" />
+ android:src="@drawable/badge_update_dark"
+ android:layout_gravity="top"
+ android:layout_width="42dp"
+ android:paddingEnd="4dp"
+ android:contentDescription="@null"
+ android:background="@null" />
gone 2016/02/13 00:26:15 Given that these two things have similar attribute
Theresa 2016/02/16 18:21:53 I made 3 new styles. I could go either way on havi
</FrameLayout>
</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698