Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <!-- The toolbar containing the URL bar, back button, and NTP button. | 6 <!-- The toolbar containing the URL bar, back button, and NTP button. |
| 7 --> | 7 --> |
| 8 | 8 |
| 9 <org.chromium.chrome.browser.toolbar.ToolbarPhone | 9 <org.chromium.chrome.browser.toolbar.ToolbarPhone |
| 10 xmlns:android="http://schemas.android.com/apk/res/android" | 10 xmlns:android="http://schemas.android.com/apk/res/android" |
| (...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 69 android:layout_gravity="top" | 69 android:layout_gravity="top" |
| 70 android:layout_width="42dp" | 70 android:layout_width="42dp" |
| 71 android:paddingEnd="4dp" | 71 android:paddingEnd="4dp" |
| 72 android:src="@drawable/btn_menu" | 72 android:src="@drawable/btn_menu" |
| 73 android:contentDescription="@string/accessibility_toolbar_btn_me nu" | 73 android:contentDescription="@string/accessibility_toolbar_btn_me nu" |
| 74 android:background="@null" /> | 74 android:background="@null" /> |
| 75 | 75 |
| 76 <ImageView | 76 <ImageView |
| 77 android:id="@+id/menu_badge" | 77 android:id="@+id/menu_badge" |
| 78 style="@style/UpdateMenuBadge" | 78 style="@style/UpdateMenuBadge" |
| 79 android:src="@drawable/badge_update" | 79 android:src="@drawable/badge_update_dark" |
| 80 android:layout_marginEnd="8.5dp" | 80 android:layout_gravity="top" |
| 81 android:contentDescription="@null" /> | 81 android:layout_width="42dp" |
| 82 android:paddingEnd="4dp" | |
| 83 android:contentDescription="@null" | |
| 84 android:background="@null" /> | |
|
gone
2016/02/13 00:26:15
Given that these two things have similar attribute
Theresa
2016/02/16 18:21:53
I made 3 new styles. I could go either way on havi
| |
| 82 </FrameLayout> | 85 </FrameLayout> |
| 83 </LinearLayout> | 86 </LinearLayout> |
| 84 | 87 |
| 85 <org.chromium.chrome.browser.widget.ToolbarProgressBar | 88 <org.chromium.chrome.browser.widget.ToolbarProgressBar |
| 86 android:id="@+id/progress" | 89 android:id="@+id/progress" |
| 87 android:layout_width="match_parent" | 90 android:layout_width="match_parent" |
| 88 android:layout_height="2dp" | 91 android:layout_height="2dp" |
| 89 chrome:progressBarColor="@color/progress_bar_foreground" | 92 chrome:progressBarColor="@color/progress_bar_foreground" |
| 90 chrome:backgroundColor="@color/progress_bar_background" /> | 93 chrome:backgroundColor="@color/progress_bar_background" /> |
| 91 | 94 |
| 92 </org.chromium.chrome.browser.toolbar.ToolbarPhone> | 95 </org.chromium.chrome.browser.toolbar.ToolbarPhone> |
| OLD | NEW |