components/autofill/core/browser/autofill_profile.cc - Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_profile.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc ('K') | « components/autofill/core/browser/autofill_metrics.cc ('k') | components/autofill/core/browser/autofill_regex_constants.cc » ('j') | components/autofill/core/browser/autofill_regex_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_profile.cc

diff --git a/components/autofill/core/browser/autofill_profile.cc b/components/autofill/core/browser/autofill_profile.cc

index e055fa6c349125eae49f82edf41becaebc7d33ca..a8098d1fd2ab98f87b8f47ea88b84b7e8cdd76f2 100644

--- a/components/autofill/core/browser/autofill_profile.cc

+++ b/components/autofill/core/browser/autofill_profile.cc

@@ -292,6 +292,7 @@ AutofillProfile& AutofillProfile::operator=(const AutofillProfile& profile) {

return *this;

}

+// TODO(crbug.com/589535): Disambiguate similar field types before uploading.

void AutofillProfile::GetMatchingTypes(

const base::string16& text,

const std::string& app_locale,