components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc - Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_ie_toolbar_import_win.cc ('K') | « components/autofill/core/browser/autofill_ie_toolbar_import_win.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/autofill_regex_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

diff --git a/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc b/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

index 29bf783c61d32e1660c2dc1748d625c0ce070d00..a452da3f6e42b594dae5109dac02f7bf4b4452f6 100644

--- a/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

+++ b/components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc

@@ -61,14 +61,15 @@ ValueDescription profile2[] = {

};

ValueDescription credit_card[] = {

- { L"credit_card_name", L"Tommy Gun" },

- // "4111111111111111" encrypted:

- { L"credit_card_number", L"\xE53F\x19AB\xC1BF\xC9EB\xECCC\x9BDA\x8515"

- L"\xE14D\x6852\x80A8\x50A3\x4375\xFD9F\x1E07"

- L"\x790E\x7336\xB773\xAF33\x93EA\xB846\xEC89"

- L"\x265C\xD0E6\x4E23\xB75F\x7983" },

- { L"credit_card_exp_month", L"11" },

- { L"credit_card_exp_4_digit_year", L"2011" },

+ {L"CREDIT_CARD_NAME_FULL", L"Tommy Gun"},

Mathieu 2016/02/24 21:58:26 fix to lower

sebsg 2016/03/01 16:32:53 Done.

+ // "4111111111111111" encrypted:

+ {L"credit_card_number",

+ L"\xE53F\x19AB\xC1BF\xC9EB\xECCC\x9BDA\x8515"

+ L"\xE14D\x6852\x80A8\x50A3\x4375\xFD9F\x1E07"

+ L"\x790E\x7336\xB773\xAF33\x93EA\xB846\xEC89"

+ L"\x265C\xD0E6\x4E23\xB75F\x7983"},

+ {L"credit_card_exp_month", L"11"},

+ {L"credit_card_exp_4_digit_year", L"2011"},

};

ValueDescription empty_salt = {

@@ -186,7 +187,8 @@ TEST_F(AutofillIeToolbarImportTest, TestAutofillImport) {

EXPECT_EQ(profile2[3].value, profiles[0].GetRawInfo(COMPANY_NAME));

ASSERT_EQ(1U, credit_cards.size());

- EXPECT_EQ(credit_card[0].value, credit_cards[0].GetRawInfo(CREDIT_CARD_NAME));

+ EXPECT_EQ(credit_card[0].value,

+ credit_cards[0].GetRawInfo(CREDIT_CARD_NAME_FULL));

EXPECT_EQ(L"4111111111111111",

credit_cards[0].GetRawInfo(CREDIT_CARD_NUMBER));

EXPECT_EQ(credit_card[2].value,