components/autofill/core/browser/autofill_metrics.cc - Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc ('K') | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/autofill_profile.cc » ('j') | components/autofill/core/browser/autofill_regex_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics.cc

diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc

index 82befa42225e539b88ad671fbd267f62b3ddb46e..508d00c666fb0860451c7f91cbc1f3623961f777 100644

--- a/components/autofill/core/browser/autofill_metrics.cc

+++ b/components/autofill/core/browser/autofill_metrics.cc

@@ -31,7 +31,7 @@ enum FieldTypeGroupForMetrics {

GROUP_PHONE,

GROUP_FAX, // Deprecated.

GROUP_EMAIL,

- GROUP_CREDIT_CARD_NAME,

+ GROUP_CREDIT_CARD_NAME_FULL,

GROUP_CREDIT_CARD_NUMBER,

GROUP_CREDIT_CARD_DATE,

GROUP_CREDIT_CARD_TYPE,

@@ -129,8 +129,8 @@ int GetFieldTypeGroupMetric(ServerFieldType field_type,

case CREDIT_CARD:

switch (field_type) {

- case CREDIT_CARD_NAME:

- group = GROUP_CREDIT_CARD_NAME;

+ case CREDIT_CARD_NAME_FULL:

+ group = GROUP_CREDIT_CARD_NAME_FULL;

break;

case CREDIT_CARD_NUMBER:

group = GROUP_CREDIT_CARD_NUMBER;