[Autofill] Add credit card first and last name heuristics predictions.

Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST. Modified the heuristics to recognize these two new fields. Added code to be able to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-vFr2LRU0FlVEhGa09uSDA

Since it's still pretty conservative. It won't fix sites like Cabelas.com where the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

TBR=thestig@chromium.org

BUG=579174
TEST=AutofillManagerTest, FormStructureTest

Committed: https://crrev.com/0a8abd1cd85e42b969740ca38e01df01ff244743
Cr-Commit-Position: refs/heads/master@{#378551}

[sebsg, 2016-02-12 16:46:09]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-02-12 16:48:19]

Description was changed from

==========
[Autofill] Add credit card first and last name heuristics predictions.

BUG=579174
==========

to

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

[sebsg, 2016-02-12 16:48:19]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2016-02-12 16:49:48]

Could you please take a look? Thanks!

[Mathieu, 2016-02-12 20:53:30]

Please include example of pages where this parsing logic now correctly detects
first and last names.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_data_util.h (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_data_util.h:20: // splitting.
documentation?

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/field_types.h (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/field_types.h:156: // No new types can be added
without a corresponding change to the Autofill
Please investigate what it would need on the server side.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/form_structure_unittest.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1707: // the
beginning of the form. The fist name has to contains some credit card
nit:first

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1709:
TEST_F(FormStructureTest, CreditCardSplitNames_first) {
more descriptive name?

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1749:
EXPECT_EQ(CREDIT_CARD_NUMBER, form_structure->field(2)->heuristic_type());
nit: can they be in order?

[sebsg, 2016-02-15 19:51:00]

Description was changed from

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

to

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

[Mathieu, 2016-02-23 15:23:03]

more comments :)

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_field.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:502: // See
http://crbug.com/441488 for potential improvements to the server
this bug has been closed, but I believe we are not 100% confident in CC
predictions. Please open another bug and link it here, to investigate how well
we are doing.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_regex_constants.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_regex_constants.cc:139: const char
kLastNameOnCardContextualRe[] =
I wonder if kLastNameRe would do?

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_type.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_type.cc:105: case CREDIT_CARD_NAME:
should probably rename CREDIT_CARD_NAME_FULL.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/form_structure_unittest.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1650: // the in the
middle of the form.
fix comment

[sebsg, 2016-02-24 16:53:49]

Description was changed from

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

to

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month 
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

[sebsg, 2016-02-24 18:43:49]

Patchset #2 (id:40001) has been deleted

[sebsg, 2016-02-24 18:49:44]

PTAL :)

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_data_util.h (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_data_util.h:20: // splitting.
On 2016/02/12 20:53:30, Mathieu Perreault wrote:
> documentation?

Done.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_field.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:502: // See
http://crbug.com/441488 for potential improvements to the server
On 2016/02/23 15:23:03, Mathieu Perreault wrote:
> this bug has been closed, but I believe we are not 100% confident in CC
> predictions. Please open another bug and link it here, to investigate how well
> we are doing. 

Done.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_regex_constants.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_regex_constants.cc:139: const char
kLastNameOnCardContextualRe[] =
On 2016/02/23 15:23:03, Mathieu Perreault wrote:
> I wonder if kLastNameRe would do?

Done.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_type.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_type.cc:105: case CREDIT_CARD_NAME:
On 2016/02/23 15:23:03, Mathieu Perreault wrote:
> should probably rename CREDIT_CARD_NAME_FULL.

Done.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/field_types.h (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/field_types.h:156: // No new types can be added
without a corresponding change to the Autofill
On 2016/02/12 20:53:30, Mathieu Perreault wrote:
> Please investigate what it would need on the server side.

The CL on the server side has been submitted. In the CL the new types are not
uploaded. I added a TODO but there is another TODO blocking it.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
File components/autofill/core/browser/form_structure_unittest.cc (right):

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1650: // the in the
middle of the form.
On 2016/02/23 15:23:03, Mathieu Perreault wrote:
> fix comment

Done.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1707: // the
beginning of the form. The fist name has to contains some credit card
On 2016/02/12 20:53:30, Mathieu Perreault wrote:
> nit:first

Done.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1709:
TEST_F(FormStructureTest, CreditCardSplitNames_first) {
On 2016/02/12 20:53:30, Mathieu Perreault wrote:
> more descriptive name?

Done.

https://codereview.chromium.org/1694443004/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure_unittest.cc:1749:
EXPECT_EQ(CREDIT_CARD_NUMBER, form_structure->field(2)->heuristic_type());
On 2016/02/12 20:53:30, Mathieu Perreault wrote:
> nit: can they be in order?

Done.

[Mathieu, 2016-02-24 21:58:26]

lgtm with nits

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/autofill_ie_toolbar_import_win.cc (right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/autofill_ie_toolbar_import_win.cc:127:
{CREDIT_CARD_NAME_FULL, L"CREDIT_CARD_NAME_FULL"},
fix to lowercase

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc
(right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc:64:
{L"CREDIT_CARD_NAME_FULL", L"Tommy Gun"},
fix to lower

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/autofill_regex_constants.cc (right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/autofill_regex_constants.cc:127:
"card.?(?:holder|owner)|name.*\\bon\\b.*card|nameoncard"
modify the second token to name.*(\\b)?on(\\b)?.*?card instead. 

Tested on http://www.regexpal.com/ (you'll need to remove one of the two \ in
\\b if you test with that site).

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:115: // Search for
"last.*name" or "name.*last". Since these are dangerously
we are now using the fuller kLastNameRe so your comment is not entirely correct.

[sebsg, 2016-03-01 16:32:53]

Could you please take another look?

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/autofill_ie_toolbar_import_win.cc (right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/autofill_ie_toolbar_import_win.cc:127:
{CREDIT_CARD_NAME_FULL, L"CREDIT_CARD_NAME_FULL"},
On 2016/02/24 21:58:26, Mathieu Perreault wrote:
> fix to lowercase

Done.

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc
(right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/autofill_ie_toolbar_import_win_unittest.cc:64:
{L"CREDIT_CARD_NAME_FULL", L"Tommy Gun"},
On 2016/02/24 21:58:26, Mathieu Perreault wrote:
> fix to lower

Done.

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/autofill_regex_constants.cc (right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/autofill_regex_constants.cc:127:
"card.?(?:holder|owner)|name.*\\bon\\b.*card|nameoncard"
On 2016/02/24 21:58:26, Mathieu Perreault wrote:
> modify the second token to name.*(\\b)?on(\\b)?.*?card instead. 
> 
> Tested on http://www.regexpal.com/ (you'll need to remove one of the two \ in
> \\b if you test with that site). 

Nice, I think I need to learn more about regexes!

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1694443004/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:115: // Search for
"last.*name" or "name.*last". Since these are dangerously
On 2016/02/24 21:58:26, Mathieu Perreault wrote:
> we are now using the fuller kLastNameRe so your comment is not entirely
correct.

Done.

[sebsg, 2016-03-01 20:30:09]

sebsg@chromium.org changed reviewers:
+ tbr:thestig@chromium.org

[sebsg, 2016-03-01 20:32:06]

sebsg@chromium.org changed reviewers:
+ tbr=thestig@chromium.org
- tbr:thestig@chromium.org

[sebsg, 2016-03-01 20:33:17]

Description was changed from

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month 
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

to

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month 
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

TBR=thestig@chromium.org

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

[sebsg, 2016-03-01 20:36:17]

sebsg@chromium.org changed reviewers:
+ thestig@chromium.org
- tbr=thestig@chromium.org

[sebsg, 2016-03-01 20:36:18]

Hi thestig@, putting you as TBR for the name change of CREDIT_CARD_NAME to
CREDIT_CARD_NAME_FULL in 

chrome/browser/extensions/*
chrome/browser/sync/*
chrome/browser/ui/*

Thanks!

[sebsg, 2016-03-01 20:36:35]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-03-01 20:36:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1694443004/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-01 20:37:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694443004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694443004/140001

[commit-bot: I haz the power, 2016-03-01 20:45:14]

Description was changed from

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month 
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

TBR=thestig@chromium.org

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

to

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month 
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

TBR=thestig@chromium.org

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

[commit-bot: I haz the power, 2016-03-01 20:45:16]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-03-01 20:47:13]

Description was changed from

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month 
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

TBR=thestig@chromium.org

BUG=579174
TEST=AutofillManagerTest, FormStructureTest
==========

to

==========
Added two new field types : CREDIT_CARD_NAME_FIRST and CREDIT_CARD_NAME_LAST.
Modified the heuristics to recognize these two new fields. Added code to be able
to fill these new fields with the data already available.

This will fix Keurig.com and sites like this example:
https://f117f41fdbc2c18ce6861c4fac2e807ecf7f1d75.googledrive.com/host/0B3xzZ-...

Since it's still pretty conservative. It won't fix sites like Cabelas.com where
the fields are named "firstname" and "lastname"

The original heuristics predictions on Keurig.com were:
NAME_FIRST | card_firstNameOnCard | First Name*
NAME_LAST | card_lastNameOnCard | Last Name*
UNKNOWN_TYPE | card_accountNumber | Card Number*
UNKNOWN_TYPE | card_cardType | Card Type
UNKNOWN_TYPE |  | Please select a card type
UNKNOWN_TYPE | card_expirationMonth | Expiration Date*
UNKNOWN_TYPE |  | Month
CREDIT_CARD_EXP_MONTH | card_expirationYear | Expiration Date*
CREDIT_CARD_EXP_4_DIGIT_YEAR |  | Year |
CREDIT_CARD_VERIFICATION_CODE | card_cvNumber | Security Code*

TBR=thestig@chromium.org

BUG=579174
TEST=AutofillManagerTest, FormStructureTest

Committed: https://crrev.com/0a8abd1cd85e42b969740ca38e01df01ff244743
Cr-Commit-Position: refs/heads/master@{#378551}
==========

[commit-bot: I haz the power, 2016-03-01 20:47:15]

Patchset 6 (id:??) landed as
https://crrev.com/0a8abd1cd85e42b969740ca38e01df01ff244743
Cr-Commit-Position: refs/heads/master@{#378551}

[Lei Zhang, 2016-05-19 20:14:35]

On 2016/03/01 20:36:18, sebsg wrote:
> Hi thestig@, putting you as TBR for the name change of CREDIT_CARD_NAME to
> CREDIT_CARD_NAME_FULL in 
> 
> chrome/browser/extensions/*
> chrome/browser/sync/*
> chrome/browser/ui/*
> 
> Thanks!

A belated lgtm for you!