Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/credit_card_field_unittest.cc

Issue 1694443004: [Autofill] Add credit card first and last name heuristics predictions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/credit_card_field.cc ('k') | components/autofill/core/browser/credit_card_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/credit_card_field_unittest.cc
diff --git a/components/autofill/core/browser/credit_card_field_unittest.cc b/components/autofill/core/browser/credit_card_field_unittest.cc
index a68c66885e43fba7e1112704072d2f0ab30c7a99..263505ffe234ab1c675f7e829101338946ea69a1 100644
--- a/components/autofill/core/browser/credit_card_field_unittest.cc
+++ b/components/autofill/core/browser/credit_card_field_unittest.cc
@@ -156,7 +156,7 @@ TEST_F(CreditCardFieldTest, ParseFullCreditCard) {
field_candidates_map_[ASCIIToUTF16("type")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number")) !=
field_candidates_map_.end());
@@ -201,7 +201,7 @@ TEST_F(CreditCardFieldTest, ParseExpMonthYear) {
AddClassifications();
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number2")) !=
field_candidates_map_.end());
@@ -242,7 +242,7 @@ TEST_F(CreditCardFieldTest, ParseExpMonthYear2) {
AddClassifications();
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number2")) !=
field_candidates_map_.end());
@@ -279,7 +279,7 @@ TEST_F(CreditCardFieldTest, ParseExpField) {
AddClassifications();
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number2")) !=
field_candidates_map_.end());
@@ -312,7 +312,7 @@ TEST_F(CreditCardFieldTest, ParseExpField2DigitYear) {
AddClassifications();
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number2")) !=
field_candidates_map_.end());
@@ -346,7 +346,7 @@ TEST_F(CreditCardFieldTest, ParseExpField2DigitYearDueToMaxLength) {
AddClassifications();
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number2")) !=
field_candidates_map_.end());
@@ -379,7 +379,7 @@ TEST_F(CreditCardFieldTest, ParseExpField4DigitYear) {
AddClassifications();
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number2")) !=
field_candidates_map_.end());
@@ -404,7 +404,7 @@ TEST_F(CreditCardFieldTest, ParseCreditCardHolderNameWithCCFullName) {
AddClassifications();
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
}
@@ -573,7 +573,7 @@ TEST_F(CreditCardFieldTest, ParseMultipleCreditCardNumbers) {
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("name1")) !=
field_candidates_map_.end());
- EXPECT_EQ(CREDIT_CARD_NAME,
+ EXPECT_EQ(CREDIT_CARD_NAME_FULL,
field_candidates_map_[ASCIIToUTF16("name1")].BestHeuristicType());
ASSERT_TRUE(field_candidates_map_.find(ASCIIToUTF16("number2")) !=
field_candidates_map_.end());
« no previous file with comments | « components/autofill/core/browser/credit_card_field.cc ('k') | components/autofill/core/browser/credit_card_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698