[Autofill] Add credit card first and last name heuristics predictions.

components/autofill/core/browser/credit_card_field.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card_field.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 93 matching lines @@
       // fields. So we search for "name" only when we've already parsed at
       // least one other credit card field and haven't yet parsed the
       // expiration date (which usually appears at the end).
       if (fields > 0 &&
           !credit_card_field->expiration_month_ &&
           ParseField(scanner,
                      base::UTF8ToUTF16(kNameOnCardContextualRe),
                      &credit_card_field->cardholder_)) {
         continue;
       }
+    } else if (!credit_card_field->cardholder_last_) {
+      // Search for "last.*name" or "name.*last". Since these are dangerously

[Mathieu, 2016/02/24 21:58:26]

we are now using the fuller kLastNameRe so your comment is not entirely correct.

[sebsg, 2016/03/01 16:32:53]

Done.

+      // generic searches, we search for these only after we have found a valid
+      // first name and haven't yet parsed the expiration date (which
+      // usually appears at the end).
+      if (!credit_card_field->expiration_month_ &&
+          ParseField(scanner, base::UTF8ToUTF16(kLastNameRe),
+                     &credit_card_field->cardholder_last_)) {
+        continue;
+      }
     }
 
     // Check for a credit card type (Visa, MasterCard, etc.) field.
     // All CC type fields encountered so far have been of type select.
     if (!credit_card_field->type_ && LikelyCardTypeSelectField(scanner)) {
       credit_card_field->type_ = scanner->Cursor();
       scanner->Advance();
       continue;
     }
 
@@ skipping 195 matching lines @@
   }
 
   ok = ok && AddClassification(type_, CREDIT_CARD_TYPE, map);
   ok = ok &&
        AddClassification(verification_, CREDIT_CARD_VERIFICATION_CODE, map);
 
   // If the heuristics detected first and last name in separate fields,
   // then ignore both fields. Putting them into separate fields is probably
   // wrong, because the credit card can also contain a middle name or middle
   // initial.
-  if (cardholder_last_ == nullptr)
-    ok = ok && AddClassification(cardholder_, CREDIT_CARD_NAME, map);
+  if (cardholder_last_ == nullptr) {
+    ok = ok && AddClassification(cardholder_, CREDIT_CARD_NAME_FULL, map);
+  } else {
+    ok = ok && AddClassification(cardholder_, CREDIT_CARD_NAME_FIRST, map);
+    ok = ok && AddClassification(cardholder_last_, CREDIT_CARD_NAME_LAST, map);
+  }
 
   if (expiration_date_) {
     DCHECK(!expiration_month_);
     DCHECK(!expiration_year_);
     ok =
         ok && AddClassification(expiration_date_, GetExpirationYearType(), map);
   } else {
     ok = ok && AddClassification(expiration_month_, CREDIT_CARD_EXP_MONTH, map);
     ok =
         ok && AddClassification(expiration_year_, GetExpirationYearType(), map);
@@ skipping 112 matching lines @@
 
 ServerFieldType CreditCardField::GetExpirationYearType() const {
   return (expiration_date_
               ? exp_year_type_
               : ((expiration_year_ && expiration_year_->max_length == 2)
                      ? CREDIT_CARD_EXP_2_DIGIT_YEAR
                      : CREDIT_CARD_EXP_4_DIGIT_YEAR));
 }
 
 }  // namespace autofill