sandwich: Aggregates metrics per URLs

sandwich: Aggregates metrics per URLs

BUG=582080
Committed: https://crrev.com/eb00ce505fec519a6ca3206e4e3d69e60837abd4
Cr-Commit-Position: refs/heads/master@{#375583}

[gabadie, 2016-02-15 14:40:49]

gabadie@chromium.org changed reviewers:
+ lizeb@chromium.org, mattcary@chromium.org, pasko@chromium.org

[gabadie, 2016-02-15 14:40:49]

lizeb@chromium.org & mattcary@chromium.org: PTAL.

[Benoit L, 2016-02-16 10:52:39]

lgtm

https://codereview.chromium.org/1694253002/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1694253002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:348:
_SaveChromeTrace(tracing_track.ToJsonDict(), args.output,
This changes the initial numbering, is that intended?

[mattcary, 2016-02-16 12:55:22]

lgtm

https://codereview.chromium.org/1694253002/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1694253002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:339: if (len(run_infos['urls']) == 0 and
args.cache_op == 'save' or
More pythonic to use not run_infos['urls'] rather than comparing len() with 0.

[gabadie, 2016-02-16 13:17:10]

Thanks! =)

https://codereview.chromium.org/1694253002/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1694253002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:339: if (len(run_infos['urls']) == 0 and
args.cache_op == 'save' or
On 2016/02/16 12:55:22, mattcary wrote:
> More pythonic to use not run_infos['urls'] rather than comparing len() with 0.

Done.

https://codereview.chromium.org/1694253002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:348:
_SaveChromeTrace(tracing_track.ToJsonDict(), args.output,
On 2016/02/16 10:52:39, Benoit L wrote:
> This changes the initial numbering, is that intended?

Yes now it starts from 0 instead of 1. This is intended so that the traces'
directory names have corresponding id to the url it is associated with in the
run_infos['urls'] list.

[gabadie, 2016-02-16 15:11:21]

The CQ bit was checked by gabadie@chromium.org

[gabadie, 2016-02-16 15:11:21]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org,
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/1694253002/#ps20001
(title: "Addresses matt's nit")

[commit-bot: I haz the power, 2016-02-16 15:12:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694253002/20001

[commit-bot: I haz the power, 2016-02-16 15:53:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:52:59]

Description was changed from

==========
sandwich: Aggregates metrics per URLs

BUG=582080
==========

to

==========
sandwich: Aggregates metrics per URLs

BUG=582080

Committed: https://crrev.com/eb00ce505fec519a6ca3206e4e3d69e60837abd4
Cr-Commit-Position: refs/heads/master@{#375583}
==========

[commit-bot: I haz the power, 2016-02-16 22:52:59]

Patchset 2 (id:??) landed as
https://crrev.com/eb00ce505fec519a6ca3206e4e3d69e60837abd4
Cr-Commit-Position: refs/heads/master@{#375583}