Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1701973002: sandwich: Implements reload cache operation to compare with push. (Closed)

Created:
4 years, 10 months ago by gabadie
Modified:
4 years, 10 months ago
Reviewers:
Benoit L, mattcary
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@d06
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandwich: Implements reload cache operation to compare with push. BUG=582080 Committed: https://crrev.com/bbcc51966eccb4e6dc7c4ecf2ad8e04add8ac1bc Cr-Commit-Position: refs/heads/master@{#375594}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addresses matt's nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M tools/android/loading/run_sandwich.py View 1 3 chunks +30 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
gabadie
lizeb@chromium.org & mattcary@chromium.org: PTAL.
4 years, 10 months ago (2016-02-16 13:21:21 UTC) #2
mattcary
lgtm https://codereview.chromium.org/1701973002/diff/1/tools/android/loading/run_sandwich.py File tools/android/loading/run_sandwich.py (right): https://codereview.chromium.org/1701973002/diff/1/tools/android/loading/run_sandwich.py#newcode94 tools/android/loading/run_sandwich.py:94: target_directory: Directory path where to create this particular ...
4 years, 10 months ago (2016-02-16 13:28:29 UTC) #3
gabadie
New revision uploaded. lizeb@chromium.org: PTAL. https://codereview.chromium.org/1701973002/diff/1/tools/android/loading/run_sandwich.py File tools/android/loading/run_sandwich.py (right): https://codereview.chromium.org/1701973002/diff/1/tools/android/loading/run_sandwich.py#newcode94 tools/android/loading/run_sandwich.py:94: target_directory: Directory path where ...
4 years, 10 months ago (2016-02-16 13:40:07 UTC) #4
Benoit L
On 2016/02/16 13:40:07, gabadie wrote: > New revision uploaded. > > mailto:lizeb@chromium.org: PTAL. > > ...
4 years, 10 months ago (2016-02-16 14:27:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701973002/20001
4 years, 10 months ago (2016-02-16 16:13:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 16:44:36 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:53:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbcc51966eccb4e6dc7c4ecf2ad8e04add8ac1bc
Cr-Commit-Position: refs/heads/master@{#375594}

Powered by Google App Engine
This is Rietveld 408576698