tools/android/loading/pull_sandwich_metrics_unittest.py - Issue 1694253002: sandwich: Aggregates metrics per URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/pull_sandwich_metrics_unittest.py

Issue 1694253002: sandwich: Aggregates metrics per URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@d05

Patch Set: Addresses matt's nit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/loading/pull_sandwich_metrics_unittest.py

diff --git a/tools/android/loading/pull_sandwich_metrics_unittest.py b/tools/android/loading/pull_sandwich_metrics_unittest.py

index ad9fbe1be7dd42afa8ff81373ce70dae91d7e873..3c985087161c61288fb71b8869be4334d3375413 100644

--- a/tools/android/loading/pull_sandwich_metrics_unittest.py

+++ b/tools/android/loading/pull_sandwich_metrics_unittest.py

@@ -146,6 +146,8 @@ class PageTrackTest(unittest.TestCase):

def testCommandLine(self):

tmp_dir = tempfile.mkdtemp()

+ with open(os.path.join(tmp_dir, 'run_infos.json'), 'w') as out_file:

+ json.dump({'urls': ['a.com', 'b.com', 'c.org']}, out_file)

for dirname in ['1', '2', 'whatever']:

os.mkdir(os.path.join(tmp_dir, dirname))

with open(os.path.join(tmp_dir, dirname, 'trace.json'), 'w') as out_file: