Center browser dialogs with respect to docked devtools

Center browser dialogs with respect to docked devtools

Currently browser dialogs are centered relatively to the main
webcontents. If one has docked devtools which occupy 90% of the browser
window, the dialog is hardly seen.

This patch makes dialogs to be centered with respect to open devtools,
which means centering to the container of both inspected webcontents
and and devtools.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252048

[lushnikov, 2014-02-17 15:45:23]

Please take a look on this change.

[dgozman, 2014-02-17 16:03:03]

What about the Mac/Gtk ports?

https://codereview.chromium.org/169403004/diff/1/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_view_layout.cc (right):

https://codereview.chromium.org/169403004/diff/1/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_view_layout.cc:82: views::View* view =
browser_view_layout_->contents_container_;
You want devtools_web_view_ from BrowserView here. Contents container may have a
top margin, which should be taken into account. Try showing dialog on a new tab
page for example.

[lushnikov, 2014-02-18 14:16:12]

On 2014/02/17 16:03:03, dgozman wrote:
> What about the Mac/Gtk ports?

Both Mac/Gtk ports center message per window

[dgozman, 2014-02-18 14:17:37]

lgtm. I'm not an owner though.

[lushnikov, 2014-02-18 18:17:06]

@sky: could you please review this change?

https://codereview.chromium.org/169403004/diff/1/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_view_layout.cc (right):

https://codereview.chromium.org/169403004/diff/1/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_view_layout.cc:82: views::View* view =
browser_view_layout_->contents_container_;
On 2014/02/17 16:03:03, dgozman wrote:
> You want devtools_web_view_ from BrowserView here. Contents container may have
a
> top margin, which should be taken into account. Try showing dialog on a new
tab
> page for example.

Left as-is due to offline discussion.

[sky, 2014-02-18 21:22:52]

LGTM

[lushnikov, 2014-02-19 05:40:10]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-02-19 05:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lushnikov@chromium.org/169403004/1

[commit-bot: I haz the power, 2014-02-19 06:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 06:38:00]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[lushnikov, 2014-02-19 09:01:31]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-02-19 09:01:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lushnikov@chromium.org/169403004/1

[commit-bot: I haz the power, 2014-02-19 14:54:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lushnikov@chromium.org/169403004/1

[commit-bot: I haz the power, 2014-02-19 15:27:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lushnikov@chromium.org/169403004/1

[commit-bot: I haz the power, 2014-02-19 19:44:22]

Change committed as 252048