Center browser dialogs with respect to docked devtools

chrome/browser/ui/views/frame/browser_view_layout.cc

Index: chrome/browser/ui/views/frame/browser_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc
index 9f2d995e25ff68fad3fa4b286e0624f7ab0fd16a..7f22c404cbc19c63df8397e28b3170521e5b2a27 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout.cc
@@ -79,7 +79,7 @@ class BrowserViewLayout::WebContentsModalDialogHostViews
   }
 
   virtual gfx::Point GetDialogPosition(const gfx::Size& size) OVERRIDE {
-    views::View* view = browser_view_layout_->delegate_->GetContentsWebView();
+    views::View* view = browser_view_layout_->contents_container_;

[dgozman, 2014/02/17 16:03:03]

You want devtools_web_view_ from BrowserView here. Contents container may have a
top margin, which should be taken into account. Try showing dialog on a new tab
page for example.

[lushnikov, 2014/02/18 18:17:06]

Left as-is due to offline discussion.

     gfx::Rect content_area = view->ConvertRectToWidget(view->GetLocalBounds());
     const int middle_x = content_area.x() + content_area.width() / 2;
     const int top = browser_view_layout_->web_contents_modal_dialog_top_y_;
@@ -87,7 +87,7 @@ class BrowserViewLayout::WebContentsModalDialogHostViews
   }
 
   virtual gfx::Size GetMaximumDialogSize() OVERRIDE {
-    views::View* view = browser_view_layout_->delegate_->GetContentsWebView();
+    views::View* view = browser_view_layout_->contents_container_;
     gfx::Rect content_area = view->ConvertRectToWidget(view->GetLocalBounds());
     const int top = browser_view_layout_->web_contents_modal_dialog_top_y_;
     return gfx::Size(content_area.width(), content_area.bottom() - top);