Center browser dialogs with respect to docked devtools

chrome/browser/ui/views/frame/browser_view_layout.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
 
 #include "base/observer_list.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 61 matching lines @@
                       OnHostDestroying());
   }
 
   void NotifyPositionRequiresUpdate() {
     FOR_EACH_OBSERVER(ModalDialogHostObserver,
                       observer_list_,
                       OnPositionRequiresUpdate());
   }
 
   virtual gfx::Point GetDialogPosition(const gfx::Size& size) OVERRIDE {
-    views::View* view = browser_view_layout_->delegate_->GetContentsWebView();
+    views::View* view = browser_view_layout_->contents_container_;

[dgozman, 2014/02/17 16:03:03]

You want devtools_web_view_ from BrowserView here. Contents container may have a
top margin, which should be taken into account. Try showing dialog on a new tab
page for example.

[lushnikov, 2014/02/18 18:17:06]

Left as-is due to offline discussion.

     gfx::Rect content_area = view->ConvertRectToWidget(view->GetLocalBounds());
     const int middle_x = content_area.x() + content_area.width() / 2;
     const int top = browser_view_layout_->web_contents_modal_dialog_top_y_;
     return gfx::Point(middle_x - size.width() / 2, top);
   }
 
   virtual gfx::Size GetMaximumDialogSize() OVERRIDE {
-    views::View* view = browser_view_layout_->delegate_->GetContentsWebView();
+    views::View* view = browser_view_layout_->contents_container_;
     gfx::Rect content_area = view->ConvertRectToWidget(view->GetLocalBounds());
     const int top = browser_view_layout_->web_contents_modal_dialog_top_y_;
     return gfx::Size(content_area.width(), content_area.bottom() - top);
   }
 
  private:
   virtual gfx::NativeView GetHostView() const OVERRIDE {
     gfx::NativeWindow window =
         browser_view_layout_->browser()->window()->GetNativeWindow();
     return views::Widget::GetWidgetForNativeWindow(window)->GetNativeView();
@@ skipping 483 matching lines @@
   return bottom;
 }
 
 bool BrowserViewLayout::InfobarVisible() const {
   // Cast to a views::View to access GetPreferredSize().
   views::View* infobar_container = infobar_container_;
   // NOTE: Can't check if the size IsEmpty() since it's always 0-width.
   return browser_->SupportsWindowFeature(Browser::FEATURE_INFOBAR) &&
       (infobar_container->GetPreferredSize().height() != 0);
 }