Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1693833002: Remove strong mode support from binary operations. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove strong mode support from binary operations. R=bmeurer@chromium.org BUG=v8:3956 LOG=n Committed: https://crrev.com/1150092b29bcafba2a6c38fa394b137ec53ff426 Cr-Commit-Position: refs/heads/master@{#34036}

Patch Set 1 #

Patch Set 2 : Skip some tests. #

Patch Set 3 : Remove outside TurboFan as well. #

Patch Set 4 : Rebased and tests disabled. #

Patch Set 5 : Fix mistake. #

Total comments: 2

Patch Set 6 : Addressed comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+817 lines, -1928 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 9 chunks +12 lines, -35 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 8 chunks +11 lines, -35 lines 0 comments Download
M src/code-factory.h View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M src/code-factory.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 5 chunks +9 lines, -17 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 2 chunks +15 lines, -15 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 3 3 chunks +17 lines, -19 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +14 lines, -29 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +15 lines, -53 lines 0 comments Download
M src/compiler/js-operator.cc View 5 chunks +67 lines, -183 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 6 chunks +2 lines, -30 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 3 11 chunks +63 lines, -99 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 2 3 4 32 chunks +52 lines, -88 lines 2 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 2 3 9 chunks +37 lines, -45 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 5 chunks +6 lines, -10 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 5 chunks +6 lines, -11 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 5 chunks +7 lines, -10 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 5 chunks +6 lines, -11 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 5 chunks +6 lines, -11 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 5 chunks +6 lines, -10 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 5 chunks +7 lines, -10 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 5 chunks +7 lines, -10 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 6 chunks +17 lines, -35 lines 0 comments Download
M src/ic/ic.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 5 chunks +24 lines, -38 lines 0 comments Download
M src/ic/ic-state.h View 1 2 3 4 5 3 chunks +4 lines, -11 lines 0 comments Download
M src/ic/ic-state.cc View 1 2 5 chunks +3 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 3 2 chunks +4 lines, -21 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 8 chunks +7 lines, -15 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 8 chunks +17 lines, -39 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 9 chunks +12 lines, -34 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +40 lines, -41 lines 0 comments Download
M src/objects.cc View 1 2 3 13 chunks +18 lines, -91 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 chunks +8 lines, -12 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 2 3 9 chunks +12 lines, -35 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 2 chunks +1 line, -14 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
M src/runtime/runtime-operators.cc View 1 2 11 chunks +0 lines, -133 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 6 chunks +17 lines, -35 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 3 6 chunks +15 lines, -33 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 2 3 27 chunks +73 lines, -128 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 2 3 12 chunks +19 lines, -19 lines 0 comments Download
M test/mjsunit/messages.js View 1 2 3 2 chunks +1 line, -7 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 4 chunks +5 lines, -145 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 8 chunks +36 lines, -53 lines 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 2 chunks +17 lines, -66 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 2 3 8 chunks +50 lines, -55 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
titzer
lgtm with tear
4 years, 10 months ago (2016-02-12 15:21:12 UTC) #3
Michael Starzinger
Will adapt test expectations on Tuesday when I am back.
4 years, 10 months ago (2016-02-12 16:21:22 UTC) #6
Michael Starzinger
PTAL. This is ready for review. Andreas: Please sign off on the overall change. Benedikt: ...
4 years, 10 months ago (2016-02-16 12:23:20 UTC) #7
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 10 months ago (2016-02-16 12:23:58 UTC) #8
Michael Starzinger
+Toon: For the runtime and stub changes.
4 years, 10 months ago (2016-02-16 12:24:53 UTC) #10
Toon Verwaest
lgtm https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h#newcode1683 src/code-stubs.h:1683: // Bit 3 is unused, feel free to ...
4 years, 10 months ago (2016-02-16 12:38:35 UTC) #12
Michael Starzinger
https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h#newcode1683 src/code-stubs.h:1683: // Bit 3 is unused, feel free to use ...
4 years, 10 months ago (2016-02-16 13:14:32 UTC) #13
rossberg
LGTM (Gummistempel)
4 years, 10 months ago (2016-02-16 13:14:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693833002/100001
4 years, 10 months ago (2016-02-16 13:32:42 UTC) #17
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-16 13:47:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693833002/100001
4 years, 10 months ago (2016-02-16 13:52:35 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-16 13:54:59 UTC) #24
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/1150092b29bcafba2a6c38fa394b137ec53ff426 Cr-Commit-Position: refs/heads/master@{#34036}
4 years, 10 months ago (2016-02-16 13:55:38 UTC) #26
adamk
https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydrogen-instructions.h File src/crankshaft/hydrogen-instructions.h (left): https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydrogen-instructions.h#oldcode4106 src/crankshaft/hydrogen-instructions.h:4106: if (!is_strong(strength)) SetFlag(kAllowUndefinedAsNaN); This deletion looks wrong: it should ...
4 years, 6 months ago (2016-06-22 19:57:18 UTC) #28
rossberg
4 years, 6 months ago (2016-06-23 06:28:31 UTC) #29
Message was sent while issue was closed.
https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydroge...
File src/crankshaft/hydrogen-instructions.h (left):

https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydroge...
src/crankshaft/hydrogen-instructions.h:4106: if (!is_strong(strength))
SetFlag(kAllowUndefinedAsNaN);
On 2016/06/22 19:57:18, adamk wrote:
> This deletion looks wrong: it should have instead unconditionally set the
> kAllowUndefinedAsNaN flag.
> 
> I happened to investigate this as part of
> https://bugs.chromium.org/p/chromium/issues/detail?id=621147; doubt it's
> related, but figured it was worth pointing out.

C negation syntax, made easy to overlook since 1972.

Powered by Google App Engine
This is Rietveld 408576698