Remove strong mode support from binary operations.

Remove strong mode support from binary operations.

R=bmeurer@chromium.org
BUG=v8:3956
LOG=n

Committed: https://crrev.com/1150092b29bcafba2a6c38fa394b137ec53ff426
Cr-Commit-Position: refs/heads/master@{#34036}

[Michael Starzinger, 2016-02-12 15:13:45]

Description was changed from

==========
[turbofan] Remove strong mode support from binary ops.

R=
==========

to

==========
Remove strong mode support from binary operations.

R=
==========

[titzer, 2016-02-12 15:21:11]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2016-02-12 15:21:12]

lgtm with tear

[Michael Starzinger, 2016-02-12 16:20:08]

Description was changed from

==========
Remove strong mode support from binary operations.

R=
==========

to

==========
Remove strong mode support from binary operations.

R=bmeurer@chromium.org
==========

[Michael Starzinger, 2016-02-12 16:20:08]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org, rossberg@chromium.org

[Michael Starzinger, 2016-02-12 16:21:22]

Will adapt test expectations on Tuesday when I am back.

[Michael Starzinger, 2016-02-16 12:23:20]

PTAL. This is ready for review.

Andreas: Please sign off on the overall change.
Benedikt: PTAL at the TurboFan pieces.

[Benedikt Meurer, 2016-02-16 12:23:58]

LGTM (rubber-stamped)

[Michael Starzinger, 2016-02-16 12:24:52]

mstarzinger@chromium.org changed reviewers:
+ verwaest@chromium.org

[Michael Starzinger, 2016-02-16 12:24:53]

+Toon: For the runtime and stub changes.

[Michael Starzinger, 2016-02-16 12:35:25]

Description was changed from

==========
Remove strong mode support from binary operations.

R=bmeurer@chromium.org
==========

to

==========
Remove strong mode support from binary operations.

R=bmeurer@chromium.org
BUG=v8:3956
LOG=n
==========

[Toon Verwaest, 2016-02-16 12:38:35]

lgtm

https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h#newcod...
src/code-stubs.h:1683: // Bit 3 is unused, feel free to use at own discretion.
Could shift up the other bits rather than adding a comment :)

[Michael Starzinger, 2016-02-16 13:14:32]

https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1693833002/diff/80001/src/code-stubs.h#newcod...
src/code-stubs.h:1683: // Bit 3 is unused, feel free to use at own discretion.
On 2016/02/16 12:38:34, Toon Verwaest wrote:
> Could shift up the other bits rather than adding a comment :)

Done. Same for BinaryOpICState as well.

[rossberg, 2016-02-16 13:14:53]

LGTM (Gummistempel)

[Michael Starzinger, 2016-02-16 13:32:33]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-02-16 13:32:34]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
bmeurer@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1693833002/#ps100001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-02-16 13:32:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693833002/100001

[commit-bot: I haz the power, 2016-02-16 13:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 13:47:23]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[commit-bot: I haz the power, 2016-02-16 13:47:26]

The CQ bit was unchecked by commit-bot@chromium.org

[Michael Starzinger, 2016-02-16 13:52:29]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-02-16 13:52:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693833002/100001

[commit-bot: I haz the power, 2016-02-16 13:54:58]

Description was changed from

==========
Remove strong mode support from binary operations.

R=bmeurer@chromium.org
BUG=v8:3956
LOG=n
==========

to

==========
Remove strong mode support from binary operations.

R=bmeurer@chromium.org
BUG=v8:3956
LOG=n
==========

[commit-bot: I haz the power, 2016-02-16 13:54:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-16 13:55:37]

Description was changed from

==========
Remove strong mode support from binary operations.

R=bmeurer@chromium.org
BUG=v8:3956
LOG=n
==========

to

==========
Remove strong mode support from binary operations.

R=bmeurer@chromium.org
BUG=v8:3956
LOG=n

Committed: https://crrev.com/1150092b29bcafba2a6c38fa394b137ec53ff426
Cr-Commit-Position: refs/heads/master@{#34036}
==========

[commit-bot: I haz the power, 2016-02-16 13:55:38]

Patchset 6 (id:??) landed as
https://crrev.com/1150092b29bcafba2a6c38fa394b137ec53ff426
Cr-Commit-Position: refs/heads/master@{#34036}

[adamk, 2016-06-22 19:57:17]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-06-22 19:57:18]

https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydroge...
File src/crankshaft/hydrogen-instructions.h (left):

https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydroge...
src/crankshaft/hydrogen-instructions.h:4106: if (!is_strong(strength))
SetFlag(kAllowUndefinedAsNaN);
This deletion looks wrong: it should have instead unconditionally set the
kAllowUndefinedAsNaN flag.

I happened to investigate this as part of
https://bugs.chromium.org/p/chromium/issues/detail?id=621147; doubt it's
related, but figured it was worth pointing out.

[rossberg, 2016-06-23 06:28:31]

https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydroge...
File src/crankshaft/hydrogen-instructions.h (left):

https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydroge...
src/crankshaft/hydrogen-instructions.h:4106: if (!is_strong(strength))
SetFlag(kAllowUndefinedAsNaN);
On 2016/06/22 19:57:18, adamk wrote:
> This deletion looks wrong: it should have instead unconditionally set the
> kAllowUndefinedAsNaN flag.
> 
> I happened to investigate this as part of
> https://bugs.chromium.org/p/chromium/issues/detail?id=621147; doubt it's
> related, but figured it was worth pointing out.

C negation syntax, made easy to overlook since 1972.