Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
index c0abbc85889a2a9f6cfeb1b8abe9a6909d4ca74f..6a6981bd9cdcc4a9c1dde002b4753064dcccbfae 100644
--- a/src/interpreter/bytecode-array-builder.cc
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -220,25 +220,13 @@ void BytecodeArrayBuilder::Output(Bytecode bytecode) {
bytecodes()->push_back(Bytecodes::ToByte(bytecode));
}
-
BytecodeArrayBuilder& BytecodeArrayBuilder::BinaryOperation(Token::Value op,
- Register reg,
- Strength strength) {
- if (is_strong(strength)) {
- UNIMPLEMENTED();
- }
-
+ Register reg) {
Output(BytecodeForBinaryOperation(op), reg.ToRawOperand());
return *this;
}
-
-BytecodeArrayBuilder& BytecodeArrayBuilder::CountOperation(Token::Value op,
- Strength strength) {
- if (is_strong(strength)) {
- UNIMPLEMENTED();
- }
-
+BytecodeArrayBuilder& BytecodeArrayBuilder::CountOperation(Token::Value op) {
Output(BytecodeForCountOperation(op));
return *this;
}
@@ -255,13 +243,8 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::TypeOf() {
return *this;
}
-
-BytecodeArrayBuilder& BytecodeArrayBuilder::CompareOperation(
- Token::Value op, Register reg, Strength strength) {
- if (is_strong(strength)) {
- UNIMPLEMENTED();
- }
-
+BytecodeArrayBuilder& BytecodeArrayBuilder::CompareOperation(Token::Value op,
+ Register reg) {
Output(BytecodeForCompareOperation(op), reg.ToRawOperand());
return *this;
}

Powered by Google App Engine
This is Rietveld 408576698