src/compiler/js-generic-lowering.h - Issue 1693833002: Remove strong mode support from binary operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.h

Issue 1693833002: Remove strong mode support from binary operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-generic-lowering.h

diff --git a/src/compiler/js-generic-lowering.h b/src/compiler/js-generic-lowering.h

index ffce9126df74472808ef1d283f649e9370bfa172..f4acdf63056eac79e6bfa16bff000e4b96d6ecab 100644

--- a/src/compiler/js-generic-lowering.h

+++ b/src/compiler/js-generic-lowering.h

@@ -36,7 +36,7 @@ class JSGenericLowering final : public Reducer {

#undef DECLARE_LOWER

// Helpers to replace existing nodes with a generic call.

- void ReplaceWithCompareIC(Node* node, Token::Value token, Strength strength);

+ void ReplaceWithCompareIC(Node* node, Token::Value token);

void ReplaceWithStubCall(Node* node, Callable c, CallDescriptor::Flags flags);

void ReplaceWithRuntimeCall(Node* node, Runtime::FunctionId f, int args = -1);