Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1693443003: Revert of SkHalfToFloat_01 / SkFloatToHalf_01 (Closed)

Created:
4 years, 10 months ago by mtklein
Modified:
4 years, 10 months ago
Reviewers:
jvanverth1, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkHalfToFloat_01 / SkFloatToHalf_01 (patchset #11 id:200001 of https://codereview.chromium.org/1685133005/ ) Reason for revert: Gotta fix Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Original issue's description: > SkHalfToFloat_01 / SkFloatToHalf_01 > > These are basically inlined, 4-at-a-time versions of our existing functions, > but cut down to avoid any work that's only necessary outside [0,1]. > > Both f16 and f32 denorms should work fine modulo the usual ARMv7 NEON denorm==zero caveat. > > In exchange for a little speed, f32->f16 does not round properly. > Instead it truncates, so it's never off by more than 1 bit. > > Support for finite values >1 or <0 is straightforward to add back. > >1 might already work as-is. > > Getting close to _u16 performance: > micros bench > 261.13 xferu64_bw_1_opaque_u16 > 1833.51 xferu64_bw_1_alpha_u16 > 2762.32 ? xferu64_aa_1_opaque_u16 > 3334.29 xferu64_aa_1_alpha_u16 > 249.78 xferu64_bw_1_opaque_f16 > 3383.18 xferu64_bw_1_alpha_f16 > 4214.72 xferu64_aa_1_opaque_f16 > 4701.19 xferu64_aa_1_alpha_f16 > > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685133005 > > Committed: https://skia.googlesource.com/skia/+/9ea11a4235b3e3521cc8bf914a27c2d0dc062db9 TBR=jvanverth@google.com,reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cbefc5e4ca7fd7aaa5d2a3aa85b30f16148c3d2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -100 lines) Patch
M src/core/SkHalf.h View 2 chunks +0 lines, -63 lines 0 comments Download
M src/core/SkXfermodeU64.cpp View 1 chunk +23 lines, -2 lines 0 comments Download
M tests/Float16Test.cpp View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of SkHalfToFloat_01 / SkFloatToHalf_01
4 years, 10 months ago (2016-02-11 14:00:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693443003/1
4 years, 10 months ago (2016-02-11 14:00:43 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 14:00:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cbefc5e4ca7fd7aaa5d2a3aa85b30f16148c3d2f

Powered by Google App Engine
This is Rietveld 408576698