Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: tests/Float16Test.cpp

Issue 1693443003: Revert of SkHalfToFloat_01 / SkFloatToHalf_01 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkXfermodeU64.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/Float16Test.cpp
diff --git a/tests/Float16Test.cpp b/tests/Float16Test.cpp
index f96d9045673a7b6313e0082e611452d3933f5576..f437268c79faedacab7f02df01ebd2d33c917cff 100644
--- a/tests/Float16Test.cpp
+++ b/tests/Float16Test.cpp
@@ -10,7 +10,6 @@
#include "SkHalf.h"
#include "SkOpts.h"
#include "SkPixmap.h"
-#include "SkRandom.h"
static bool eq_within_half_float(float a, float b) {
const float kTolerance = 1.0f / (1 << (8 + 10));
@@ -65,37 +64,3 @@
SkOpts::half_to_float(fscratch, hs, 7);
REPORTER_ASSERT(reporter, 0 == memcmp(fscratch, fs, sizeof(fs)));
}
-
-DEF_TEST(HalfToFloat_01, r) {
- for (uint16_t h = 0; h < 0x8000; h++) {
- float f = SkHalfToFloat(h);
- if (f >= 0 && f <= 1) {
- REPORTER_ASSERT(r, SkHalfToFloat_01(h)[0] == f);
- REPORTER_ASSERT(r, SkFloatToHalf_01(SkHalfToFloat_01(h)) == h);
- }
- }
-}
-
-DEF_TEST(FloatToHalf_01, r) {
-#if 0
- for (uint32_t bits = 0; bits < 0x80000000; bits++) {
-#else
- SkRandom rand;
- for (int i = 0; i < 1000000; i++) {
- uint32_t bits = rand.nextU();
-#endif
- float f;
- memcpy(&f, &bits, 4);
- if (f >= 0 && f <= 1) {
- uint16_t h1 = (uint16_t)SkFloatToHalf_01(Sk4f(f,0,0,0)),
- h2 = SkFloatToHalf(f);
- bool ok = (h1 == h2 || h1 == h2-1);
- REPORTER_ASSERT(r, ok);
- if (!ok) {
- SkDebugf("%08x (%d) -> %04x (%d), want %04x (%d)\n",
- bits, bits>>23, h1, h1>>10, h2, h2>>10);
- break;
- }
- }
- }
-}
« no previous file with comments | « src/core/SkXfermodeU64.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698