Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1693083004: Move scanner out of generated and clean up imports (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1014 lines, -2536 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 3 chunks +123 lines, -122 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 5 chunks +144 lines, -143 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/organize_directives.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/sort_members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/source_range.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/validator.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 5 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_declaration_visitor_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/stress/replay/replay.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/example/parser_driver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/example/scanner_driver.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/analyzer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/dart/ast/token.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/token.dart View 9 chunks +22 lines, -63 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 8 chunks +127 lines, -127 lines 0 comments Download
A pkg/analyzer/lib/src/dart/scanner/reader.dart View 1 chunk +187 lines, -0 lines 0 comments Download
A + pkg/analyzer/lib/src/dart/scanner/scanner.dart View 2 chunks +2 lines, -186 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 14 chunks +54 lines, -54 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 9 chunks +17 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_scanner.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 1 chunk +3 lines, -1551 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 9 chunks +39 lines, -41 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/token_factory.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/yaml.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/dart/ast/ast_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/constant_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/incremental_scanner_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 8 chunks +129 lines, -131 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I cleaned up some comments in two files (analyzer/lib/dart/ast/token.dart and analyzer/lib/src/dart/ast/token.dart), and removed a prefix ...
4 years, 10 months ago (2016-02-13 22:12:28 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-14 01:17:43 UTC) #3
Brian Wilkerson
4 years, 10 months ago (2016-02-14 15:48:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
71e7ed86c060ff2d695777d2c68c20e25cfb8ef9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698