pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 1693083004: Move scanner out of generated and clean up imports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1693083004: Move scanner out of generated and clean up imports (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: clean up Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index 5cfdacef0120bf9de9db13431207ad612a3c9b19..ae59416e9637c4e23e2364cebe3bc72858e3c249 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -18,15 +18,16 @@ import 'package:analysis_server/src/services/completion/dart/common_usage_sorter

import 'package:analysis_server/src/services/completion/dart/contribution_sorter.dart';

import 'package:analysis_server/src/services/completion/dart/optype.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

+import 'package:analyzer/dart/ast/token.dart';

import 'package:analyzer/dart/element/element.dart';

import 'package:analyzer/dart/element/type.dart';

import 'package:analyzer/file_system/file_system.dart';

import 'package:analyzer/src/context/context.dart'

show AnalysisFutureHelper, AnalysisContextImpl;

+import 'package:analyzer/src/dart/ast/token.dart';

import 'package:analyzer/src/generated/ast.dart';

import 'package:analyzer/src/generated/engine.dart' hide AnalysisContextImpl;

import 'package:analyzer/src/generated/java_engine.dart';

-import 'package:analyzer/src/generated/scanner.dart';

import 'package:analyzer/src/generated/source.dart';

import 'package:analyzer/src/task/dart.dart';

import 'package:analyzer/task/dart.dart';

@@ -365,8 +366,12 @@ class DartCompletionRequestImpl implements DartCompletionRequest {

return dartRequest;

}

- static Future _computeAsync(CompletionRequest request, AnalysisTarget target,

- ResultDescriptor descriptor, CompletionPerformance performance, String perfTag) async {

+ static Future _computeAsync(

+ CompletionRequest request,

+ AnalysisTarget target,

+ ResultDescriptor descriptor,

+ CompletionPerformance performance,

+ String perfTag) async {

request.checkAborted();

performance.logStartTime(perfTag);

var result;