Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart

Issue 1693083004: Move scanner out of generated and clean up imports (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: clean up Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.src.refactoring.naming_conventions; 5 library services.src.refactoring.naming_conventions;
6 6
7 import 'package:analysis_server/src/services/correction/status.dart'; 7 import 'package:analysis_server/src/services/correction/status.dart';
8 import 'package:analysis_server/src/services/correction/strings.dart'; 8 import 'package:analysis_server/src/services/correction/strings.dart';
9 import 'package:analyzer/src/generated/scanner.dart'; 9 import 'package:analyzer/dart/ast/token.dart';
10 10
11 /** 11 /**
12 * Returns the [RefactoringStatus] with severity: 12 * Returns the [RefactoringStatus] with severity:
13 * OK if the name is valid; 13 * OK if the name is valid;
14 * WARNING if the name is discouraged; 14 * WARNING if the name is discouraged;
15 * FATAL if the name is illegal. 15 * FATAL if the name is illegal.
16 */ 16 */
17 RefactoringStatus validateClassName(String name) { 17 RefactoringStatus validateClassName(String name) {
18 return _validateUpperCamelCase(name, "Class"); 18 return _validateUpperCamelCase(name, "Class");
19 } 19 }
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 } 255 }
256 // does not start with upper case 256 // does not start with upper case
257 if (!isUpperCase(identifier.codeUnitAt(0))) { 257 if (!isUpperCase(identifier.codeUnitAt(0))) {
258 // By convention, class names usually start with an uppercase letter 258 // By convention, class names usually start with an uppercase letter
259 String message = "$desc should start with an uppercase letter."; 259 String message = "$desc should start with an uppercase letter.";
260 return new RefactoringStatus.warning(message); 260 return new RefactoringStatus.warning(message);
261 } 261 }
262 // OK 262 // OK
263 return new RefactoringStatus(); 263 return new RefactoringStatus();
264 } 264 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/inline_local.dart ('k') | pkg/analysis_server/lib/src/status/validator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698