Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1688803003: [NaCl SDK] convert build_sdk from gyp to gn (Closed)

Created:
4 years, 10 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] convert build_sdk from gyp to gn CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG=585999 Committed: https://crrev.com/c32ba313009772295f0f4d84d5a6e33fbfc63463 Cr-Commit-Position: refs/heads/master@{#376530}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -199 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 6 chunks +106 lines, -199 lines 0 comments Download

Messages

Total messages: 64 (32 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/1
4 years, 10 months ago (2016-02-10 23:42:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/20001
4 years, 10 months ago (2016-02-11 00:06:33 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_nacl_sdk on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_nacl_sdk/builds/729)
4 years, 10 months ago (2016-02-11 00:41:38 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/40001
4 years, 10 months ago (2016-02-11 00:46:03 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_nacl_sdk on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_nacl_sdk/builds/732)
4 years, 10 months ago (2016-02-11 01:23:43 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/80001
4 years, 10 months ago (2016-02-11 19:35:15 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/49029)
4 years, 10 months ago (2016-02-11 20:27:58 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/100001
4 years, 10 months ago (2016-02-11 22:48:29 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_nacl_sdk on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/builds/681)
4 years, 10 months ago (2016-02-11 23:50:23 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/120001
4 years, 10 months ago (2016-02-11 23:59:46 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_nacl_sdk on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_nacl_sdk/builds/738)
4 years, 10 months ago (2016-02-12 00:43:05 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/140001
4 years, 10 months ago (2016-02-12 01:04:31 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/65631)
4 years, 10 months ago (2016-02-12 01:23:21 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/180001
4 years, 10 months ago (2016-02-12 19:00:49 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/200001
4 years, 10 months ago (2016-02-12 19:03:56 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/220001
4 years, 10 months ago (2016-02-12 20:37:27 UTC) #33
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/143015)
4 years, 10 months ago (2016-02-12 20:44:39 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/240001
4 years, 10 months ago (2016-02-13 03:18:51 UTC) #37
Sam Clegg
4 years, 10 months ago (2016-02-13 03:19:50 UTC) #38
Sam Clegg
4 years, 10 months ago (2016-02-13 03:19:58 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/280001
4 years, 10 months ago (2016-02-18 18:19:52 UTC) #42
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_nacl_sdk on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/builds/691)
4 years, 10 months ago (2016-02-18 21:10:08 UTC) #44
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/300001
4 years, 10 months ago (2016-02-19 02:20:44 UTC) #46
Sam Clegg
ptal
4 years, 10 months ago (2016-02-19 03:04:34 UTC) #47
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_nacl_sdk on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_nacl_sdk/builds/756)
4 years, 10 months ago (2016-02-19 03:19:40 UTC) #49
binji
lgtm % trybots
4 years, 10 months ago (2016-02-19 03:19:42 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/320001
4 years, 10 months ago (2016-02-19 03:34:45 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/320001
4 years, 10 months ago (2016-02-19 03:50:03 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: win_nacl_sdk on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/builds/698)
4 years, 10 months ago (2016-02-19 05:43:46 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688803003/340001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688803003/340001
4 years, 10 months ago (2016-02-19 18:17:29 UTC) #61
commit-bot: I haz the power
Committed patchset #18 (id:340001)
4 years, 10 months ago (2016-02-19 21:01:27 UTC) #62
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 21:02:54 UTC) #64
Message was sent while issue was closed.
Patchset 18 (id:??) landed as
https://crrev.com/c32ba313009772295f0f4d84d5a6e33fbfc63463
Cr-Commit-Position: refs/heads/master@{#376530}

Powered by Google App Engine
This is Rietveld 408576698