No protected data members in ProfileSyncService tests

No protected data members in ProfileSyncService tests

This CL moves data members in AbstractProfileSyncServiceTest and its
descendants into the private section and adds accessors as appropriate.

It also makes two static methods plain functions in the anonymous namespace,
enabling a friend declaration to be dropped.

R=zea@chromium.org
BUG=581640
Committed: https://crrev.com/99fcfe9f90aa1f85de156a56cff6df4991194c54
Cr-Commit-Position: refs/heads/master@{#376483}

[vabr (Chromium), 2016-02-16 18:04:27]

Hi Nicolas,

This is the refactoring you requested, in a separate CL.

The CL itself is lower priority than the other ones I sent you, because it does
not block the unforking effort. So no rush in reviewing it. :)

Cheers,
Vaclav

[Nicolas Zea, 2016-02-18 19:14:46]

LGTM!

[vabr (Chromium), 2016-02-19 09:38:47]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 09:40:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706453002/60001

[commit-bot: I haz the power, 2016-02-19 09:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 09:54:14]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-02-19 13:07:35]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 13:10:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706453002/60001

[commit-bot: I haz the power, 2016-02-19 13:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 13:26:45]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-02-19 15:54:56]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 15:58:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706453002/60001

[commit-bot: I haz the power, 2016-02-19 16:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 16:14:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-02-19 17:30:27]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-02-19 17:30:27]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1706453002/#ps60001
(title: "Just rebased")

[commit-bot: I haz the power, 2016-02-19 17:34:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706453002/60001

[commit-bot: I haz the power, 2016-02-19 17:42:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-19 17:44:18]

Description was changed from

==========
No protected data members in ProfileSyncService tests

This CL moves data members in AbstractProfileSyncServiceTest and its
descendants into the private section and adds accessors as appropriate.

It also makes two static methods plain functions in the anonymous namespace,
enabling a friend declaration to be dropped.

R=zea@chromium.org
BUG=581640
==========

to

==========
No protected data members in ProfileSyncService tests

This CL moves data members in AbstractProfileSyncServiceTest and its
descendants into the private section and adds accessors as appropriate.

It also makes two static methods plain functions in the anonymous namespace,
enabling a friend declaration to be dropped.

R=zea@chromium.org
BUG=581640

Committed: https://crrev.com/99fcfe9f90aa1f85de156a56cff6df4991194c54
Cr-Commit-Position: refs/heads/master@{#376483}
==========

[commit-bot: I haz the power, 2016-02-19 17:44:19]

Patchset 4 (id:??) landed as
https://crrev.com/99fcfe9f90aa1f85de156a56cff6df4991194c54
Cr-Commit-Position: refs/heads/master@{#376483}