Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave event on Context Menu

Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave event on Context Menu.

In issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043, 450138
Committed: https://crrev.com/eee68fae914198693c60c9691b53f25b338560e7
Cr-Commit-Position: refs/heads/master@{#375787}

[lanwei, 2016-02-11 18:31:03]

Description was changed from

==========
mouse leave win

BUG=586043
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Issue 1051613002, it creates a new variable showing_context_menu_
in RenderWidgetHostViewAura to decide when to stop mouse exited event to send
to renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

[lanwei, 2016-02-11 18:31:57]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Issue 1051613002, it creates a new variable showing_context_menu_
in RenderWidgetHostViewAura to decide when to stop mouse exited event to send
to renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

[lanwei, 2016-02-11 19:15:50]

lanwei@chromium.org changed reviewers:
+ ananta@chromium.org, sadrul@chromium.org, tdresser@chromium.org

[lanwei, 2016-02-11 19:17:00]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Issue 450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

[lanwei, 2016-02-11 19:20:33]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Issue 450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Cr 450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

[lanwei, 2016-02-11 19:20:48]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Cr 450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Cr450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

[lanwei, 2016-02-11 19:21:03]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In Cr450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In issue 450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

[lanwei, 2016-02-11 19:21:29]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In issue 450138, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043, 450138
==========

[lanwei, 2016-02-11 19:22:55]

lanwei@chromium.org changed reviewers:
+ cpu@chromium.org

[tdresser, 2016-02-11 20:07:16]

Non owner's LGTM.

[sadrul, 2016-02-12 01:06:52]

lgtm Thank you!

https://codereview.chromium.org/1692593002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/1692593002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura.cc:810: if
(showing_context_menu_)
IsShowingContextMenu()

[sadrul, 2016-02-12 15:30:12]

https://codereview.chromium.org/1692593002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/1692593002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_aura.cc:799: bool
selection_popup) {
Oh, and while you are here, make this a const function please.

[cpu_(ooo_6.6-7.5), 2016-02-14 21:12:25]

looks reasonable but I am a bit afraid you could break something on Windows.
have my lgtm but ping iyengar@goo in any case.

[ananta, 2016-02-17 02:55:23]

lgtm

[lanwei, 2016-02-17 03:31:13]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2016-02-17 03:31:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1692593002/#ps20001
(title: "Make CanRendererHandleEvent const.")

[commit-bot: I haz the power, 2016-02-17 03:34:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692593002/20001

[commit-bot: I haz the power, 2016-02-17 04:18:07]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043, 450138
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043, 450138
==========

[commit-bot: I haz the power, 2016-02-17 04:18:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-17 04:20:26]

Description was changed from

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043, 450138
==========

to

==========
Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave
event on Context Menu.

In issue 1051613002, it creates a new variable showing_context_menu_ in
RenderWidgetHostViewAura to decide when to stop mouse exited event to send to
renderer. Since we have showing_context_menu_ in RenderWidgetHostViewBase,
which is set to true when context menu opens, and false when the menu closes, we
should just use it instead of having another similar variable in
RenderWidgetHostViewAura.

BUG=586043, 450138

Committed: https://crrev.com/eee68fae914198693c60c9691b53f25b338560e7
Cr-Commit-Position: refs/heads/master@{#375787}
==========

[commit-bot: I haz the power, 2016-02-17 04:20:27]

Patchset 2 (id:??) landed as
https://crrev.com/eee68fae914198693c60c9691b53f25b338560e7
Cr-Commit-Position: refs/heads/master@{#375787}