chrome/browser/mouseleave_browsertest.cc - Issue 1692593002: Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave event on Context Menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/mouseleave_browsertest.cc

Issue 1692593002: Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave event on Context Menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make CanRendererHandleEvent const. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/mouseleave_browsertest.cc

diff --git a/chrome/browser/mouseleave_browsertest.cc b/chrome/browser/mouseleave_browsertest.cc

index eef6f859014d857cea2aa001a689064f742d0542..fd9e8738c2b598108f7caa47dc4125b991e328a9 100644

--- a/chrome/browser/mouseleave_browsertest.cc

+++ b/chrome/browser/mouseleave_browsertest.cc

@@ -107,7 +107,7 @@ IN_PROC_BROWSER_TEST_F(MouseLeaveTest, MouseDownOnBrowserCaption) {

}

#endif

-#if defined(OS_WIN) || defined(OS_MACOSX)

+#if defined(OS_MACOSX)

// Test that a mouseleave is not triggered when showing the context menu.

// If the test is failed, it means that Blink gets the mouseleave event

// when showing the context menu and it could make the unexpecting

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | no next file with comments »