Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 1692593002: Use showing_context_menu_ from RenderWidgetHostViewBase to avoid MouseLeave event on Context Menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make CanRendererHandleEvent const. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 void SetKeyboardFocus(); 490 void SetKeyboardFocus();
491 491
492 // Called when RenderWidget wants to start BeginFrame scheduling or stop. 492 // Called when RenderWidget wants to start BeginFrame scheduling or stop.
493 void OnSetNeedsBeginFrames(bool needs_begin_frames); 493 void OnSetNeedsBeginFrames(bool needs_begin_frames);
494 494
495 RenderFrameHostImpl* GetFocusedFrame(); 495 RenderFrameHostImpl* GetFocusedFrame();
496 496
497 // Returns true if the |event| passed in can be forwarded to the renderer. 497 // Returns true if the |event| passed in can be forwarded to the renderer.
498 bool CanRendererHandleEvent(const ui::MouseEvent* event, 498 bool CanRendererHandleEvent(const ui::MouseEvent* event,
499 bool mouse_locked, 499 bool mouse_locked,
500 bool selection_popup); 500 bool selection_popup) const;
501 501
502 // Returns true when we can do SurfaceHitTesting for the event type. 502 // Returns true when we can do SurfaceHitTesting for the event type.
503 bool ShouldRouteEvent(const ui::Event* event) const; 503 bool ShouldRouteEvent(const ui::Event* event) const;
504 504
505 // Called when the parent window bounds change. 505 // Called when the parent window bounds change.
506 void HandleParentBoundsChanged(); 506 void HandleParentBoundsChanged();
507 507
508 // Called when the parent window hierarchy for our window changes. 508 // Called when the parent window hierarchy for our window changes.
509 void ParentHierarchyChanged(); 509 void ParentHierarchyChanged();
510 510
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 // when the LegacyRenderWidgetHostHWND hwnd is destroyed. 649 // when the LegacyRenderWidgetHostHWND hwnd is destroyed.
650 content::LegacyRenderWidgetHostHWND* legacy_render_widget_host_HWND_; 650 content::LegacyRenderWidgetHostHWND* legacy_render_widget_host_HWND_;
651 651
652 // Set to true if the legacy_render_widget_host_HWND_ instance was destroyed 652 // Set to true if the legacy_render_widget_host_HWND_ instance was destroyed
653 // by Windows. This could happen if the browser window was destroyed by 653 // by Windows. This could happen if the browser window was destroyed by
654 // DestroyWindow for e.g. This flag helps ensure that we don't try to create 654 // DestroyWindow for e.g. This flag helps ensure that we don't try to create
655 // the LegacyRenderWidgetHostHWND instance again as that would be a futile 655 // the LegacyRenderWidgetHostHWND instance again as that would be a futile
656 // exercise. 656 // exercise.
657 bool legacy_window_destroyed_; 657 bool legacy_window_destroyed_;
658 658
659 // Set to true when a context menu is being displayed. Reset to false when
660 // a mouse leave is received in this context.
661 bool showing_context_menu_;
662
663 // Contains a copy of the last context menu request parameters. Only set when 659 // Contains a copy of the last context menu request parameters. Only set when
664 // we receive a request to show the context menu on a long press. 660 // we receive a request to show the context menu on a long press.
665 scoped_ptr<ContextMenuParams> last_context_menu_params_; 661 scoped_ptr<ContextMenuParams> last_context_menu_params_;
666 #endif 662 #endif
667 663
668 bool has_snapped_to_boundary_; 664 bool has_snapped_to_boundary_;
669 665
670 scoped_ptr<TouchSelectionControllerClientAura> selection_controller_client_; 666 scoped_ptr<TouchSelectionControllerClientAura> selection_controller_client_;
671 scoped_ptr<ui::TouchSelectionController> selection_controller_; 667 scoped_ptr<ui::TouchSelectionController> selection_controller_;
672 668
(...skipping 28 matching lines...) Expand all
701 float device_scale_factor_; 697 float device_scale_factor_;
702 698
703 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_; 699 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_;
704 700
705 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura); 701 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura);
706 }; 702 };
707 703
708 } // namespace content 704 } // namespace content
709 705
710 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 706 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
OLDNEW
« no previous file with comments | « chrome/browser/mouseleave_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698