Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1691813003: Add --auto-open-devtools-for-tabs flag. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
Nico, pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --auto-open-devtools-for-tabs flag. This flags automatically opens DevTools for every browser tab, including restored and opened for url arguments ones. BUG=410958 Committed: https://crrev.com/54cc54e1eb3620221c2f552adad047e322717adb Cr-Commit-Position: refs/heads/master@{#376916}

Patch Set 1 #

Total comments: 4

Patch Set 2 : DevToolsAutoOpener #

Patch Set 3 : rebase #

Patch Set 4 : cleanup in test #

Patch Set 5 : close last DevToolsWindow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -1 line) Patch
M chrome/browser/browser_process.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/devtools/devtools_auto_opener.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/browser/devtools/devtools_auto_opener.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/chrome_debugger.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 32 (15 generated)
dgozman
Could you please take a look?
4 years, 10 months ago (2016-02-12 00:48:28 UTC) #2
pfeldman
https://codereview.chromium.org/1691813003/diff/1/chrome/browser/devtools/chrome_devtools_discovery_provider.cc File chrome/browser/devtools/chrome_devtools_discovery_provider.cc (right): https://codereview.chromium.org/1691813003/diff/1/chrome/browser/devtools/chrome_devtools_discovery_provider.cc#newcode32 chrome/browser/devtools/chrome_devtools_discovery_provider.cc:32: if (base::CommandLine::ForCurrentProcess()->HasSwitch( How does this make sense here? https://codereview.chromium.org/1691813003/diff/1/chrome/common/chrome_switches.cc ...
4 years, 10 months ago (2016-02-12 02:15:08 UTC) #3
dgozman
Pavel, please take another look. Nico, could you please do an OWNER review of chrome/ ...
4 years, 10 months ago (2016-02-17 01:42:46 UTC) #5
pfeldman
lgtm
4 years, 10 months ago (2016-02-17 03:06:27 UTC) #6
dgozman
Nico, please take a look as a chrome/ owner.
4 years, 10 months ago (2016-02-18 20:11:56 UTC) #7
Nico
lgtm
4 years, 10 months ago (2016-02-18 20:16:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691813003/20001
4 years, 10 months ago (2016-02-18 20:31:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/23765) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-18 20:48:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691813003/40001
4 years, 10 months ago (2016-02-18 21:57:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/145408)
4 years, 10 months ago (2016-02-18 22:39:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691813003/40001
4 years, 10 months ago (2016-02-19 00:19:12 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/168940)
4 years, 10 months ago (2016-02-19 03:28:33 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691813003/60001
4 years, 10 months ago (2016-02-19 22:22:34 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/176710)
4 years, 10 months ago (2016-02-20 00:11:02 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691813003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691813003/80001
4 years, 10 months ago (2016-02-23 02:56:30 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-23 03:47:38 UTC) #30
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 03:49:13 UTC) #32
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/54cc54e1eb3620221c2f552adad047e322717adb
Cr-Commit-Position: refs/heads/master@{#376916}

Powered by Google App Engine
This is Rietveld 408576698